From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbbF3LU1 (ORCPT ); Tue, 30 Jun 2015 07:20:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47631 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbbF3LUU (ORCPT ); Tue, 30 Jun 2015 07:20:20 -0400 Date: Tue, 30 Jun 2015 13:20:18 +0200 From: Jiri Olsa To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, namhyung@kernel.org, Ingo Molnar Subject: Re: [PATCH 5/5] perf report: Fill in the missing freeing a session after an error occur Message-ID: <20150630112018.GC25631@krava.brq.redhat.com> References: <1435652124-22414-1-git-send-email-treeze.taeung@gmail.com> <1435652124-22414-6-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435652124-22414-6-git-send-email-treeze.taeung@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2015 at 05:15:24PM +0900, Taeung Song wrote: > When an error occur a error value is just returned > without freeing the session. So allocating and freeing > session have to be matched as a pair even if an error occur. > > Signed-off-by: Taeung Song Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/builtin-report.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index 32626ea..610d056 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -828,8 +828,10 @@ repeat: > if (report.header || report.header_only) { > perf_session__fprintf_info(session, stdout, > report.show_full_info); > - if (report.header_only) > - return 0; > + if (report.header_only) { > + ret = 0; > + goto error; > + } > } else if (use_browser == 0) { > fputs("# To display the perf.data header info, please use --header/--header-only options.\n#\n", > stdout); > -- > 1.9.1 >