From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbbF3LW7 (ORCPT ); Tue, 30 Jun 2015 07:22:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50945 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbbF3LWv (ORCPT ); Tue, 30 Jun 2015 07:22:51 -0400 Date: Tue, 30 Jun 2015 13:22:49 +0200 From: Jiri Olsa To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, namhyung@kernel.org, Ingo Molnar Subject: Re: [PATCH 2/5] perf kmem: Fill in the missing freeing a session after an error occur Message-ID: <20150630112249.GE25631@krava.brq.redhat.com> References: <1435652124-22414-1-git-send-email-treeze.taeung@gmail.com> <1435652124-22414-3-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435652124-22414-3-git-send-email-treeze.taeung@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2015 at 05:15:21PM +0900, Taeung Song wrote: > When an error occur a error value is just returned > without freeing the session. So allocating and freeing > session have to be matched as a pair even if an error occur. Acked-by: Jiri Olsa thanks, jirka > > Signed-off-by: Taeung Song > --- > tools/perf/builtin-kmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c > index 950f296..23b1faa 100644 > --- a/tools/perf/builtin-kmem.c > +++ b/tools/perf/builtin-kmem.c > @@ -1916,7 +1916,7 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) > if (!perf_evlist__find_tracepoint_by_name(session->evlist, > "kmem:kmalloc")) { > pr_err(errmsg, "slab", "slab"); > - return -1; > + goto out_delete; > } > } > > @@ -1927,7 +1927,7 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) > "kmem:mm_page_alloc"); > if (evsel == NULL) { > pr_err(errmsg, "page", "page"); > - return -1; > + goto out_delete; > } > > kmem_page_size = pevent_get_page_size(evsel->tp_format->pevent); > -- > 1.9.1 >