From: Greg KH <gregkh@linuxfoundation.org>
To: Kris Borer <kborer@gmail.com>
Cc: stern@rowland.harvard.edu, balbi@ti.com, pmladek@suse.cz,
antoine.tenart@free-electrons.com, hdegoede@redhat.com,
sergei.shtylyov@cogentembedded.com, rafael.j.wysocki@intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: move assignment out of if condition
Date: Tue, 30 Jun 2015 08:09:56 -0700 [thread overview]
Message-ID: <20150630150956.GA17497@kroah.com> (raw)
In-Reply-To: <1435669342-8333-1-git-send-email-kborer@gmail.com>
On Tue, Jun 30, 2015 at 09:02:22AM -0400, Kris Borer wrote:
> Fix four occurrences of the checkpatch.pl error:
>
> ERROR: do not use assignment in if condition
If you are going to do stuff like this, use Coccinelle so you are sure
you don't break the code.
Also always test your changes, if possible.
greg k-h
prev parent reply other threads:[~2015-06-30 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 13:02 [PATCH] usb: move assignment out of if condition Kris Borer
2015-06-30 13:35 ` Sergei Shtylyov
2015-06-30 13:35 ` Oliver Neukum
2015-06-30 15:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630150956.GA17497@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=antoine.tenart@free-electrons.com \
--cc=balbi@ti.com \
--cc=hdegoede@redhat.com \
--cc=kborer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmladek@suse.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox