From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbbF3PKI (ORCPT ); Tue, 30 Jun 2015 11:10:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40314 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753207AbbF3PJ7 (ORCPT ); Tue, 30 Jun 2015 11:09:59 -0400 Date: Tue, 30 Jun 2015 08:09:56 -0700 From: Greg KH To: Kris Borer Cc: stern@rowland.harvard.edu, balbi@ti.com, pmladek@suse.cz, antoine.tenart@free-electrons.com, hdegoede@redhat.com, sergei.shtylyov@cogentembedded.com, rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: move assignment out of if condition Message-ID: <20150630150956.GA17497@kroah.com> References: <1435669342-8333-1-git-send-email-kborer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435669342-8333-1-git-send-email-kborer@gmail.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2015 at 09:02:22AM -0400, Kris Borer wrote: > Fix four occurrences of the checkpatch.pl error: > > ERROR: do not use assignment in if condition If you are going to do stuff like this, use Coccinelle so you are sure you don't break the code. Also always test your changes, if possible. greg k-h