public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: CPU: 0 PID: 3634 at drivers/gpu/drm/drm_irq.c:1141 drm_wait_one_vblank
Date: Tue, 30 Jun 2015 22:13:35 +0200	[thread overview]
Message-ID: <20150630201335.GA4496@dhcp22.suse.cz> (raw)
In-Reply-To: <20150630165929.GB30960@phenom.ffwll.local>

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

On Tue 30-06-15 18:59:29, Daniel Vetter wrote:
[...]
> I looked at dmesg, nothing out of the ordinary there. Unfortunately also
> no hints why the pipe is somehow off when we think it's on. Can you please
> test the below patch and grab a new dmesg?

Attached.

> Also it might be time to start bisecting this if you can readily reproduce it.

Yes, I can reproduce it just by switching to the text console. Sometimes
it is the first attempt already but sometimes it takes several attempts.
I will try to go back to 4.0 and bisect it then.

> -Daniel
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d0f3cbc87474..b8d9314ef459 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12190,7 +12190,7 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
>  		 * flipping, so increasing its cost here shouldn't be a big
>  		 * deal).
>  		 */
> -		if (i915.fastboot && ret == 0)
> +		if (ret == 0)
>  			intel_modeset_check_state(set->crtc->dev);
>  	}
>  
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Michal Hocko
SUSE Labs

[-- Attachment #2: dmesg.gz --]
[-- Type: application/gzip, Size: 25781 bytes --]

  reply	other threads:[~2015-06-30 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 11:57 WARNING: CPU: 0 PID: 3634 at drivers/gpu/drm/drm_irq.c:1141 drm_wait_one_vblank Michal Hocko
2015-06-30 14:32 ` Daniel Vetter
2015-06-30 16:07   ` Michal Hocko
2015-06-30 16:59     ` Daniel Vetter
2015-06-30 20:13       ` Michal Hocko [this message]
2015-07-01  8:26         ` Daniel Vetter
2015-07-01 12:12           ` Michal Hocko
2015-07-01 12:23             ` Jani Nikula
2015-07-07  8:43               ` Daniel Vetter
2015-07-08  6:40                 ` Michal Hocko
2015-07-08  7:32                   ` Daniel Vetter
2015-07-08  7:46                     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150630201335.GA4496@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox