From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbbF3Wmm (ORCPT ); Tue, 30 Jun 2015 18:42:42 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:56800 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbbF3Wmh (ORCPT ); Tue, 30 Jun 2015 18:42:37 -0400 Date: Tue, 30 Jun 2015 17:42:31 -0500 From: Felipe Balbi To: Joe Perches , Greg KH CC: Felipe Balbi , Andy Whitcroft , Linux Kernel Mailing List Subject: Re: [PATCH] scripts: checkpatch: ignore stable commit annotation Message-ID: <20150630224231.GL20003@saruman.tx.rr.com> Reply-To: References: <1435702063-12871-1-git-send-email-balbi@ti.com> <1435703435.12101.50.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4OpS+d6oOtUQaRm1" Content-Disposition: inline In-Reply-To: <1435703435.12101.50.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4OpS+d6oOtUQaRm1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 30, 2015 at 03:30:35PM -0700, Joe Perches wrote: > On Tue, 2015-06-30 at 17:07 -0500, Felipe Balbi wrote: > > When running scripts/checkpatch.pl on stable commits, > > we always get the error for not using 12-character > > commit hash abbreviation with shortlog within (""). >=20 > Looking at linux-stable v3.14.44 (randomly chosen), there > are also commit entries like: >=20 > This is commit 0f540c3a7cfb91c9d7a19eb0c95c24 upstream. > commit: cb64edb6b89491edfdbae52ba7db9a8b8391d339 upstream >=20 > is -stable now using some script to tag these or is it > freehanded and happens to be reasonably consistent? afaict, Greg uses a script. Greg ? > > Because that's actually a false positive, let's ignore > > stable commit annotation. >=20 > This will have to be respun against another patch: > https://lkml.org/lkml/2015/6/19/491 >=20 > Please cc Andrew Morton if you resubmit. hmmm, he doesn't get listed on get_maintainers.pl... > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -2330,6 +2331,7 @@ sub process { > > my $orig_desc =3D "commit description"; > > my $description =3D ""; > > =20 > > + $stable =3D 1 if ($line =3D~ /\bcommit\s+[0-9a-f]{40}\s+upstream\./= i); >=20 > If these are really scripted, the case-insensitive /i > shouldn't be necessary. yeah, it was really just to be safer. What if Greg decides to change his script in the future ? --=20 balbi --4OpS+d6oOtUQaRm1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkxtXAAoJEIaOsuA1yqREL4wP/0Gol6NsOAlWJnyG6yWgv/2O c07ujqhjTXhGM/+L0KluZY68BRwna2S3FZ5lvDHLYYaKVqau6SBSrejUvMhJpefS ed7CTyhDUHINJwu9xC+Pxb27XnIdJXkRWdmFuI/512l7wb8FxcZsyHsZ1r92WZFL W6n7ZfQY60viZA+CnkiMixGHOyc1uhg/6luxKrpOMs2BMqxVPT4wE3NH1V6fek+1 K+y0rMm1voO00srJMlDYNybj7VcDEqL0Ep3NXxR9eI/rE7sFV+pLHalYVdsEQwX9 WoeTeSiDGRHetVibx+qi9TEUH6u9nsWYXfd7++qq6jT894xn+mjCF3/AYCbzPYz9 9fZRBr+5kKIxnn6dzlZh+21sa0siX21ThzwurQI52uK3nYlGtovJ8Vdd9bbMajtl KI848OE2E0og4SPMB/ow5WMmi+pZDCJymOmzWaffvpzXTDWCaoJ0lTdlKx7U4QIs 9tyXcbIOBPhZ6RbcVuvPh42jgJ/yOWaJsEzJU+xgu3okL5BXXfAik9c3LVjDsnee 5hQk1SrbtD7Q2E/nmL76XQlREKHYxyx2nPxE2vEmEbBTg1cDg/Abg3mHoEMG6ZHC 1Bh3+Sdbs82uFbbz7KZQyYyDVBVRfnNCoVxxk5Ne68U3hTgCBoeqxMd5QRmM9Oz6 mCrIIFwZ0JVxCAT3HMvE =F3KZ -----END PGP SIGNATURE----- --4OpS+d6oOtUQaRm1--