From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbbGAAyC (ORCPT ); Tue, 30 Jun 2015 20:54:02 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:58571 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbbGAAxx (ORCPT ); Tue, 30 Jun 2015 20:53:53 -0400 Date: Tue, 30 Jun 2015 19:53:48 -0500 From: Felipe Balbi To: Greg KH CC: Felipe Balbi , Joe Perches , Andy Whitcroft , Linux Kernel Mailing List Subject: Re: [PATCH] scripts: checkpatch: ignore stable commit annotation Message-ID: <20150701005348.GA15251@saruman.tx.rr.com> Reply-To: References: <1435702063-12871-1-git-send-email-balbi@ti.com> <1435703435.12101.50.camel@perches.com> <20150630224231.GL20003@saruman.tx.rr.com> <20150630234554.GA13573@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <20150630234554.GA13573@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 30, 2015 at 04:45:54PM -0700, Greg KH wrote: > On Tue, Jun 30, 2015 at 05:42:31PM -0500, Felipe Balbi wrote: > > On Tue, Jun 30, 2015 at 03:30:35PM -0700, Joe Perches wrote: > > > On Tue, 2015-06-30 at 17:07 -0500, Felipe Balbi wrote: > > > > When running scripts/checkpatch.pl on stable commits, > > > > we always get the error for not using 12-character > > > > commit hash abbreviation with shortlog within (""). > > >=20 > > > Looking at linux-stable v3.14.44 (randomly chosen), there > > > are also commit entries like: > > >=20 > > > This is commit 0f540c3a7cfb91c9d7a19eb0c95c24 upstream. > > > commit: cb64edb6b89491edfdbae52ba7db9a8b8391d339 upstream > > >=20 > > > is -stable now using some script to tag these or is it > > > freehanded and happens to be reasonably consistent? > >=20 > > afaict, Greg uses a script. Greg ? >=20 > I use a script, but my script didn't create both of those lines, only > one of them, the bottom one. The top one comes from David Miller's > scripts which he uses when he sends me networking stable patches. >=20 > Never run checkpatch on stable commits, that makes no sense at all as I > am pulling them directly from Linus's tree and there is nothing I can do > to change anything in them, nor would I ever want to. >=20 > > > If these are really scripted, the case-insensitive /i > > > shouldn't be necessary. > >=20 > > yeah, it was really just to be safer. What if Greg decides to change his > > script in the future ? >=20 > You shouldn't care, as you shouldn't be running the script and thinking > it matters, on stable tree commits. fair enough, branch deleted. I had that hunch, but since there were some complaining of checkpatch errors on stable commits, I thought about just patching it up. Thanks for confirming. cheers --=20 balbi --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkzocAAoJEIaOsuA1yqRE5EoP+wS5Ikt1oJydj3VqBgxmRiIO C7/t5mX/VXbcP72sNYb/CDL/Ptmm6issq774VILTt4i38+JQUsFAs6/NvAXdvXAo zk0KJKPy1rlF3GEGjNdg/czMrr5K1YGbHR8mon405GucDDLMZMowkvjE5QzBiNJq DBPwrew+/keeu1Ub/GBZCIu0XWLpdprzCuvJh7V6rUkLCgm8lPLtfyrrbRVI9SwF ni+HbVmVBxnQQELS5OH5mmYUthcb22ol54OySR9/JGR3s8DpXNMQxixfojUt0EJC lDWOcduGUalg+SvVZImwGYcjroEU/RCCboUHjfvLMVFrzQ29+cfmD/yNoY+3LDTz Rf1qYnKMtuChwbkChbwNGummfJF8G0XFirj3mwWkDXImJzIrvd1Mb/GYU3awrmZB JST47sf7tctJEN/glVu361pa1N73du/JD5piWW2Rm6Cx6e5ZHM97OvvNx/ahsFMI jVLRxSErfEuNERX9YwzhL9ij0oESGri8H7ynv+8+B5mNCUXZfpfjHp8mE/k3YuAj uDQjbNfTyq49/1GjmG/tKtd9OhOC9yEHE9QKu584CROXXb687yCucVx1d06w7DZ3 06VFboRQZh9ld+KIjiQk+zEFbibVYo2rA3ivxZIg93ZGeL5fJjsamYQ/VPXd5Ppw YmBh0lpd5fUjlpg/AY7Z =mWm0 -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--