From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753686AbbGAMPt (ORCPT ); Wed, 1 Jul 2015 08:15:49 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50154 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbbGAMPl (ORCPT ); Wed, 1 Jul 2015 08:15:41 -0400 Date: Wed, 1 Jul 2015 15:15:24 +0300 From: Dan Carpenter To: Clemens Ladisch Cc: Joe Perches , LKML , Julia Lawall , Andrew Morton Subject: Re: RFC: kernel coding style: prefer array to &array[0] ? Message-ID: <20150701121524.GA30834@mwanda> References: <1435685746.12101.18.camel@perches.com> <5593D4F5.1090106@ladisch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5593D4F5.1090106@ladisch.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 01, 2015 at 01:54:29PM +0200, Clemens Ladisch wrote: > Joe Perches wrote: > > It seems most in-kernel uses are 'array' rather than '&array[0]' > > > > Most of the time, using array is simpler to read than &array[0]. > > > > Exceptions exists when addresses for consecutive members are > > used like func(&array[0], &array[1]); > > I use '&array[0]' when I want to get a pointer to a single object that > happens to be the first one in an array. Yeah. Of course, you're right. Otherwise it ends up confusing static checkers if you want the first element or the whole array. > > > Should this preference be put into checkpatch and/or CodingStyle? > > How about the following low-hanging fruit? > > foo(..., &array[0], ARRAY_SIZE(array), ...) Yes, to this also. I doubt checkpatch.pl will find a meaningful number of these but doing that is annoying thing. regards, dan carpenter