From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Sohny Thomas <sohnythomas@zoho.com>
Cc: Frans Klaver <fransklaver@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
arve@android.com, riandrews@android.com, sumit.semwal@linaro.org,
maarten.lankhorst@canonical.com, carlos@cgarcia.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: android: fix coding style and TODO file
Date: Wed, 1 Jul 2015 17:49:41 +0530 [thread overview]
Message-ID: <20150701121817.GA19402@sudip-PC> (raw)
In-Reply-To: <CAH6sp9Ppb_=kX+-L_UkedkqmjdOdZwzt2PiZ3G8_bxWscZoK1Q@mail.gmail.com>
On Wed, Jul 01, 2015 at 02:07:05PM +0200, Frans Klaver wrote:
> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas <sohnythomas@zoho.com> wrote:
> > - removed non-existant issue from TODO file
>
> s,existant,existent,
>
> > kuid_t or uid_t not present in staging/android
> > - fixed 80 char limit exceeding line
> > - a newline after decelartions as per checkpatch.pl
> > - fixed an unnecessary typedef as reported by checkpatch.pl
>
> Fix one issue per patch, please.
And Signed-off-by is missing.
regards
sudip
next prev parent reply other threads:[~2015-07-01 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 11:56 [PATCH] Staging: android: fix coding style and TODO file Sohny Thomas
2015-07-01 12:07 ` Frans Klaver
2015-07-01 12:19 ` Sudip Mukherjee [this message]
2015-07-01 12:22 ` Sohny Thomas
2015-07-01 12:29 ` Frans Klaver
2015-07-01 12:38 ` Sohny Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701121817.GA19402@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=arve@android.com \
--cc=carlos@cgarcia.org \
--cc=fransklaver@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=riandrews@android.com \
--cc=sohnythomas@zoho.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox