From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sohny Thomas <sohnythomas@zoho.com>
Cc: gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, sumit.semwal@linaro.org,
carlos@cgarcia.org, kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] Staging: android: ion: fix coding style
Date: Wed, 1 Jul 2015 17:29:23 +0300 [thread overview]
Message-ID: <20150701142923.GY28762@mwanda> (raw)
In-Reply-To: <5593EF44.3050708@zoho.com>
On Wed, Jul 01, 2015 at 07:16:44PM +0530, Sohny Thomas wrote:
>
> - Fixed 80 char limit exceeding line
> and a newline after declarations as per checkpatch.pl
>
> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
> ---
> drivers/staging/android/ion/ion.c | 1 +
> drivers/staging/android/ion/ion_chunk_heap.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> struct ion_buffer *buffer;
> struct dma_buf *dmabuf;
> bool valid_handle;
> +
> DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>
> mutex_lock(&client->lock);
This is a false positive in checkpatch.pl. Just leave it as is.
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-01 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5593EA18.8060109@zoho.com>
2015-07-01 13:46 ` [PATCH v2 2/3] Staging: android: ion: fix coding style Sohny Thomas
2015-07-01 14:18 ` Frans Klaver
2015-07-01 14:29 ` Dan Carpenter [this message]
2015-07-01 15:25 ` [PATCH] checkpatch: Allow longer declaration macros Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701142923.GY28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=carlos@cgarcia.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sohnythomas@zoho.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox