From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbbGAPz5 (ORCPT ); Wed, 1 Jul 2015 11:55:57 -0400 Received: from mail-bn1bon0134.outbound.protection.outlook.com ([157.56.111.134]:50964 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754261AbbGAPzs (ORCPT ); Wed, 1 Jul 2015 11:55:48 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; Date: Wed, 1 Jul 2015 08:55:21 -0700 From: Leung Timothy Chi King To: , , , , CC: , , Subject: [PATCH] Code cleanup - else is not generally useful after a break or return Message-ID: <20150701155521.GA3613@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [220.246.161.135] X-ClientProxiedBy: HK2PR04CA0015.apcprd04.prod.outlook.com (25.162.205.153) To CY1PR12MB0731.namprd12.prod.outlook.com (25.163.238.25) X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0731;2:h3ro1avK7SgfPv6H7HZComkT6maHDolATssFU9nJ5pMXRDTpYp7eqeT2hBAN9Igw;3:FtJIKuaItu1jONTRQdugczZdcWWMEVcYb3/z0keumlVx+9JPVHmlUx4ZBdENozdohF8Z/aWcXZ3nLw5KKMjHDspts5W/svym2yIcds15GgzcwbQ1OSQY2ojOWcx0zvNMaWjL5xyc05UB0tFi3UWm8g==;25:yioCdXUmuyVBGrf9SkB3jkvgfi6oCrZS+g6bQaax3bKsBAVq1KxpgeXZtH5GjilefvuRp8xdksFssY6+9R/i35yUi58C77W8G10YHkaPfFPI2jP98plMCo34FhiYqTXXga0lJBkMxO4/0gYGYeXaqk8WdzfpoxHg+ZfDvC+8E1ZuCdFmGHlundLLeX2hAq+WxRngKxsJvTz1pCyOdWzbRS5zlYtOgqaU38dkMppYn43VSXdQy+OGaNWMFLkOFYaG7zohbUeq+I8dbt81zW23mQ==;4:89g+M64EywO+a94rbaA4r9X/6Dy7p3djNS3vP+SBFRFZdEyO031l/gX/fh4kE+ZLwv6ELP5KGWccgWeUWY7NkBhGGCyu8Nsh3PvPp6qPTw5hOqDHod6VEQQXw/NcvaBL5xIjC6leqjXVlVKWssqQEQxTyRJp9vBFxthGU4D3RvoU3PCKG9Sw1DQl/3jjW+RcxmSwknV3MaWXHMdwZcSnNljf0Hs0f185ANy2qSUKvlI0qgSwq3RtGHfGyFRzybddjWwn4CJBmR+wgKXxWAbG1l6tEiIDj++B7+od43Cvd+w= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0731; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CY1PR12MB0731;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0731; X-Forefront-PRVS: 0624A2429E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(86362001)(122386002)(189998001)(5001960100002)(54356999)(50986999)(66066001)(40100003)(92566002)(23726002)(5001770100001)(2201001)(19580395003)(77096005)(77156002)(19580405001)(83506001)(229853001)(46406003)(33716001)(74482002)(46102003)(47776003)(50466002)(4001350100001)(62966003)(42186005)(33656002)(97756001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR12MB0731;H:ubuntu;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0731;23:IO46uJ9SjsUINO40fN0pTqhiALRvaJCNqyPwJxBwZUOT92BaybMQJw5b0zw4XssFakqCB+FqftooDV0G8r+3FO1mdC5E2HvHaszTxKpVXqElZ5vPH3gsV8HpzZBQD4izsopOALl1hIG3RKnBBWF9GEeM5odaJMiXGnDmrKisg++2OxnLZb4HSx2sxEUiteD8ymwOGpLx+iJDc4JfpsD7Z8yF7CGqg6XYy86WmCAB9yEoJwsceX0bPaEmgOEfm0g1VVGD74zyk7YVSfKyTLpBLtM+3uetqbGfPpeOZkz0CZN8fa0NzREdt/PZnLPP+DZEzXVAbZ1UFdoNXSgjUuBAGngFGIVtkg1mcLB9Qj5o8NawIlj3zv+IxBhjrkvuYAaX3x6nfkxulVXbUgk+D+enyyI6EEvUT6hdhaZfRZEvSrN+S+ZE9o1iVJxK9DIOfANnrgwXBNbpIZ7wipGzlxuBeyfrjv40dQyR9LrjwQVGY6rMZaxZ4EQ5BoTZ3PxQvBvMnsd4384C92adcuxOuuC90p0Wze8GQoxi4GrzQ/5zLA6PtRq3v7+356e5GwiIEEhY6jcr4tW3vysJvKV2LeOg6onCpCUp3saZaIj1b8yrIuXwbR+2GIgwCYoThCe0zfKGdeqkMiH1nkl26IRIpAbzNkdiZXcHEhYsRNIeXQ+ePVRhc+XREOZ/eMBnNIDmktLmVpD6apcAd5QWhnlFiGg0aOFP9ytO+onDB7hRQXZ4WaOmOjg+Z0UMiGSS/T88Fb5MeGmoivGdfu2vYyk2P1QRcy+kgrx6tTWcPoTawfSrvgtC4JNiVQZCH4k8+D/ELsRjjjkJ/La14RB+r8Wq62LLfA== X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0731;5:Kr13U9M47PSpObASDVgdTLah5Uxa9cl9ommxLcZVA6Gh4hu1OKPefY4ikojIv6NSWtTjZ5b8Ot2rk0Vo046eevAO2PD3Y9XXIP0CEoDbgxK9oZK/+Dm4mPRDsmWZ3GY8TwkOXp/3pRst6PcsvvAgTw==;24:za+GD83ry/psZCn1EAKJqUtiYePYrT+V9pstPn2OfyiCXQ9Q/j7cnS5+URziNTl2BxRizdM7hNzc7xJlwfmBwpe4VFVlcRahOwPoIfzwGx0=;20:8Suu28ARBtdxaK+47bvdi23hKof1hWsjorvpoLzTeRaoiObAx/uhUB1JZjZsomYq+983q1+pEPzFnF+4dMq2UA== X-OriginatorOrg: timothyleung.co X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2015 15:55:37.8056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0731 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ran checkpatch.pl on driver/staging/rts5208/sd.c and foudn a WARNING 'else is not generally useful after a break or return' on line 3523. I removed the else without affecting the logic and the WARNING is gone. I had compiled and modprobe rts5208 to double check as well. Regards, Tim Signed-off-by: Leung Timothy Chi King --- drivers/staging/rts5208/sd.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c index a8d657b..cb41579 100644 --- a/drivers/staging/rts5208/sd.c +++ b/drivers/staging/rts5208/sd.c @@ -3520,12 +3520,11 @@ int reset_sd_card(struct rtsx_chip *chip) if (chip->sd_io) { rtsx_trace(chip); return STATUS_FAIL; - } else { - retval = reset_mmc(chip); - if (retval != STATUS_SUCCESS) { - rtsx_trace(chip); - return STATUS_FAIL; - } + } + retval = reset_mmc(chip); + if (retval != STATUS_SUCCESS) { + rtsx_trace(chip); + return STATUS_FAIL; } } } -- 1.9.1