From: Greg KH <gregkh@linuxfoundation.org>
To: Leung Timothy Chi King <contact@timothyleung.co>
Cc: fabio.falzoi84@gmail.com, joe@perches.com,
lambert.quentin@gmail.com, tinajohnson.1234@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Code cleanup - else is not generally useful after a break or return
Date: Wed, 1 Jul 2015 09:07:40 -0700 [thread overview]
Message-ID: <20150701160740.GA31389@kroah.com> (raw)
In-Reply-To: <20150701155521.GA3613@ubuntu>
Your subject needs a hint as to what part of the kernel it is changing,
please fix that up to match what other patches have looked like for this
file.
On Wed, Jul 01, 2015 at 08:55:21AM -0700, Leung Timothy Chi King wrote:
> Ran checkpatch.pl on driver/staging/rts5208/sd.c and foudn a WARNING
> 'else is not generally useful after a break or return' on line 3523. I
> removed the else without affecting the logic and the WARNING is gone. I
> had compiled and modprobe rts5208 to double check as well.
That's good, but not needed here, please say why you did what you did,
but not in a narrative like you did.
>
> Regards,
> Tim
This isn't needed either.
Can you fix up and resend?
thanks,
greg k-h
prev parent reply other threads:[~2015-07-01 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 15:55 [PATCH] Code cleanup - else is not generally useful after a break or return Leung Timothy Chi King
2015-07-01 16:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701160740.GA31389@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=contact@timothyleung.co \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=joe@perches.com \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tinajohnson.1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox