Re: [PATCH v2 1/3] dell-laptop: Clear buffer before each SMBIOS call

Darren Hart
2015-07-07T15:53:03Z

On Tue, Jul 07, 2015 at 04:04:57PM +0200, Pali Rohár wrote:
> On Monday 06 July 2015 15:39:37 Darren Hart wrote:
> > On Mon, Jul 06, 2015 at 12:08:55PM +0200, Pali Rohár wrote:
> > > Make sure that before initializing SMBIOS call input buffer does not
> > > contain any garbage (e.g. values from previous SMBIOS call). This fix
> > > problem with passing undefined/random parameters to SMBIOS functions.
> > >
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> >
> > Queued all 3 to fixes. Thanks Pali.
> >
>
> Ok.
>
> > (I made a few minor grammatical fixes tot he commit messages, review the changes
> > if you like in the fixes branch)
> >
>
> It is OK, I'm not native speaker and I have lot of troubles with English
> language. So feel free to fix any grammatical mistakes...

You do better than I do with any other language I attempt :-) I don't feel it's
reasonable for me to nag you about commit messages, but I do need to ensure they
are clear. I'll continue to update them going forward.

--
Darren Hart
Intel Open Source Technology Center