From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037AbbGBFk2 (ORCPT ); Thu, 2 Jul 2015 01:40:28 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:33134 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472AbbGBFkT (ORCPT ); Thu, 2 Jul 2015 01:40:19 -0400 X-Helo: d03dlp01.boulder.ibm.com X-MailFrom: heiko.carstens@de.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 2 Jul 2015 07:40:10 +0200 From: Heiko Carstens To: Peter Zijlstra Cc: Linus Torvalds , Ingo Molnar , Linux Kernel Mailing List , tony.luck@intel.com, benh@kernel.crashing.org Subject: Re: smp_store_mb() oddity.. Message-ID: <20150702054010.GA4029@osiris> References: <20150701171755.GM3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150701171755.GM3644@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15070205-0017-0000-0000-00000C05DB00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 01, 2015 at 07:17:55PM +0200, Peter Zijlstra wrote: > --- > Subject: locking/arch: Make smp_store_mb() use smp_mb() > > Linus noticed that there were a few smp_store_mb() implementations that > used mb(), which is inconsistent with the new naming. > > Since all smp_store_mb() users really are about SMP ordering, not IO > ordering, change them all to be consistent. > > Cc: Tony Luck > Cc: Benjamin Herrenschmidt > Cc: Heiko Carstens > Suggested-by: Linus Torvalds > Signed-off-by: Peter Zijlstra (Intel) > --- > diff --git a/arch/s390/include/asm/barrier.h b/arch/s390/include/asm/barrier.h > index e6f8615a11eb..a4dea6050c77 100644 > --- a/arch/s390/include/asm/barrier.h > +++ b/arch/s390/include/asm/barrier.h > @@ -36,7 +36,7 @@ > #define smp_mb__before_atomic() smp_mb() > #define smp_mb__after_atomic() smp_mb() > > -#define smp_store_mb(var, value) do { WRITE_ONCE(var, value); mb(); } while (0) > +#define smp_store_mb(var, value) do { WRITE_ONCE(var, value); smp_mb(); } while (0) > > #define smp_store_release(p, v) \ for the s390 part: Acked-by: Heiko Carstens