Re: [PATCH v4 14/17] x86/asm/entry/64: Migrate error and interrupt exit work to C

Ingo Molnar
2015-07-05T08:43:22Z

* Andy Lutomirski <luto@amacapital.net> wrote:

> >> I'm torn on this one. In principle, you're right, or we could have a macro
> >> CALL_ENTER_FROM_USER_MODE that does nothing if context tracking is off.
> >> OTOH, that's also kind of messy.
> >
> > busybox has IF() macros:
> >
> > IF_CONTEXT_TRACKING(call enter_from_user_mode)
> >
> > Unlike #if, this needs one line, not three.
>
> I predict all of these call sites will get moved to C before 4.3. If not, then
> I'd be glad to clean this part up.

Ok, let's see how it works out.

I think in the initial phase we should be conservative and should attempt to
introduce as few unrelated changes as possible, and get the conversion done. The
current x86 entry code is a reasonable base to start with.

Once most of the 'mechanic' conversion is done we can do all the other changes.

The conversion itself is risky enough as-is, we want to offload as much of any
other risk to after the conversion is done.

Thanks,

Ingo