Re: [PATCH v4 10/17] x86/entry/64: Really create an error-entry-from-usermode code path

Borislav Petkov
2015-07-02T16:29:49Z

On Thu, Jul 02, 2015 at 08:33:05AM -0700, Andy Lutomirski wrote:
> "Migrate error and interrupt exit work to C" puts code between those
> labels. I could squash the patches together to make it less
> mysterious.

Nah, it is my mistake of not reviewing the whole thing first and then
sending replies. Sorry about that.

> > Also, please make all those labels local by prefixing them with .L
> > because they appear unnecesasrily in objdump output as global symbols.
>
> Will do.

Yeah, the only maybe partly advantage of having the global labels would
be to ease debuggability but one can get to the proper offset even
without those labels so...

> I'll try to think of a good shorter name. No promises :)

:-)

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--