From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754434AbbGBCRX (ORCPT ); Wed, 1 Jul 2015 22:17:23 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:25351 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754035AbbGBCRP (ORCPT ); Wed, 1 Jul 2015 22:17:15 -0400 Date: Thu, 2 Jul 2015 10:16:34 +0800 From: Jisheng Zhang To: Krzysztof Kozlowski , , , CC: , Subject: Re: [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init Message-ID: <20150702101634.6a5c9f00@xhacker> In-Reply-To: References: <1435800787-696-1-git-send-email-jszhang@marvell.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-07-02_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507020037 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Krzysztof, On Thu, 2 Jul 2015 10:56:47 +0900 Krzysztof Kozlowski wrote: > 2015-07-02 10:33 GMT+09:00 Jisheng Zhang : > > It is not needed after booting, this patch moves the arm_cpuidle_init() > > function to the __init section. > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/arm64/kernel/cpuidle.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This looks good but I think you can also mark the stub in > arch/arm64/include/asm/cpuidle.h. > Thanks for review. Has adopted your suggestion in v2. Thanks, Jisheng