From: Sergei Zviagintsev <sergei@s15v.net>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Mack <daniel@zonque.org>,
David Herrmann <dh.herrmann@googlemail.com>,
Djalal Harouni <tixxdz@opendz.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 4/5] kdbus: handle WARN_ON cases properly when decrementing quota
Date: Thu, 2 Jul 2015 13:27:48 +0300 [thread overview]
Message-ID: <20150702102748.GR17917@localhost.localdomain> (raw)
In-Reply-To: <CANq1E4Sd4Pzro36koNaejOMC_5KysG5W-j1UU5SXgLP6v7Q2Zg@mail.gmail.com>
Hi,
On Thu, Jul 02, 2015 at 10:37:05AM +0200, David Herrmann wrote:
> Hi
>
> On Sun, Jun 28, 2015 at 3:17 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> > If we spotted inconsistency, fix it by setting values to zero.
>
> Why?
>
> I prefer doing nothing and just bailing out on programming errors.
> Setting it to 0 just complicates debugging and drops possibly useful
> information ('what was the counter value at that time?').
Thank you for commenting on this! Now it seems to be clear for me.
next prev parent reply other threads:[~2015-07-02 10:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 13:17 [PATCH RFC 0/5] kdbus: minor quota code improvements Sergei Zviagintsev
2015-06-28 13:17 ` [PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota_inc() Sergei Zviagintsev
2015-07-02 8:31 ` David Herrmann
2015-07-02 9:51 ` Sergei Zviagintsev
2015-07-02 10:26 ` David Herrmann
2015-06-28 13:17 ` [PATCH RFC 2/5] kdbus: use standard kernel types in struct kdbus_quota Sergei Zviagintsev
2015-07-02 8:32 ` David Herrmann
2015-06-28 13:17 ` [PATCH RFC 3/5] kdbus: do explicit overflow check in kdbus_conn_quota_inc() Sergei Zviagintsev
2015-07-02 8:35 ` David Herrmann
2015-07-02 14:06 ` Sergei Zviagintsev
2015-06-28 13:17 ` [PATCH RFC 4/5] kdbus: handle WARN_ON cases properly when decrementing quota Sergei Zviagintsev
2015-07-02 8:37 ` David Herrmann
2015-07-02 10:27 ` Sergei Zviagintsev [this message]
2015-06-28 13:17 ` [PATCH RFC 5/5] kdbus: improve tests on incrementing quota Sergei Zviagintsev
2015-07-02 8:50 ` David Herrmann
2015-07-02 13:45 ` Sergei Zviagintsev
2015-07-02 14:13 ` Djalal Harouni
2015-07-02 17:47 ` Sergei Zviagintsev
2015-07-04 11:48 ` David Herrmann
2015-07-04 11:42 ` David Herrmann
2015-07-04 13:32 ` Sergei Zviagintsev
2015-07-06 18:48 ` [PATCH RFC 0/5] kdbus: minor quota code improvements David Herrmann
2015-07-07 16:29 ` Sergei Zviagintsev
2015-07-07 22:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702102748.GR17917@localhost.localdomain \
--to=sergei@s15v.net \
--cc=daniel@zonque.org \
--cc=dh.herrmann@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tixxdz@opendz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox