From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755028AbbGCPTi (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jul 2015 11:19:38 -0400
Received: from mail-wi0-f172.google.com ([209.85.212.172]:34374 "EHLO
	mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754965AbbGCPT3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jul 2015 11:19:29 -0400
Date: Fri, 3 Jul 2015 16:19:23 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge
 support
Message-ID: <20150703151923.GB10500@x1>
References: <cover.1435308209.git.Adam.Thomson.Opensource@diasemi.com>
 <afbda3c9439f08cbf57c184ff6b96bdf7f5ca8b4.1435308209.git.Adam.Thomson.Opensource@diasemi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <afbda3c9439f08cbf57c184ff6b96bdf7f5ca8b4.1435308209.git.Adam.Thomson.Opensource@diasemi.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 26 Jun 2015, Adam Thomson wrote:

> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
>  Documentation/devicetree/bindings/mfd/da9150.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/da9150.txt b/Documentation/devicetree/bindings/mfd/da9150.txt
> index d0588ea..8bf1a20 100644
> --- a/Documentation/devicetree/bindings/mfd/da9150.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9150.txt
> @@ -6,6 +6,7 @@ Device			 Description
>  ------			 -----------
>  da9150-gpadc		: General Purpose ADC
>  da9150-charger		: Battery Charger
> +da9150-fg		: Battery Fuel-Gauge
> 
>  ======
> 
> @@ -22,6 +23,7 @@ Required properties:
>  Sub-devices:
>  - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150-gpadc.txt
>  - da9150-charger: See Documentation/devicetree/bindings/power/da9150-charger.txt
> +- da9150-fg: See Documentation/devicetree/bindings/power/da9150-fg.txt

Can you send a subsequent patch doing:

s-Documentation/devicetree/bindings/-../-
> 
> 

Superfluous '\n' here.

>  Example:
> @@ -40,4 +42,8 @@ Example:
>  		da9150-charger {
>  			...
>  		};
> +
> +		da9150-fg {
> +			...
> +		};

Perhaps a little content wouldn't go amiss here for quick reference.

Saves dipping in and out of the other binding files.

This patch is fine though:
  Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog