From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754673AbbGCRoq (ORCPT ); Fri, 3 Jul 2015 13:44:46 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34607 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755143AbbGCRoi (ORCPT ); Fri, 3 Jul 2015 13:44:38 -0400 Date: Fri, 3 Jul 2015 10:44:05 -0700 From: Nicolin Chen To: Juergen Borleis Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Takashi Iwai , Liam Girdwood , Mark Brown , kernel@pengutronix.de, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH] ASoC: fsl-ssi: Fix bitclock calculation for master mode Message-ID: <20150703174404.GA9468@Asurada> References: <1435919976-1667-1-git-send-email-jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435919976-1667-1-git-send-email-jbe@pengutronix.de> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 03, 2015 at 12:39:36PM +0200, Juergen Borleis wrote: > According to the datasheet 'pm', 'psr' and 'div2' should never be all 0. > Since commit 541b03ad6cfe ("ASoC: fsl_ssi: Fix the incorrect limitation of > the bit clock rate") this can happen, because for some bitclock rates > 'pm' = 0 seems to be a valid choice but does not work due to hardware > restrictions. This results into a bad hardware behaviour (slow audio for > example). Feature tested on a i.MX25. > > Signed-off-by: Juergen Borleis Acked-by: Nicolin Chen Thank you! > --- > sound/soc/fsl/fsl_ssi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c > index c7647e0..c0b940e 100644 > --- a/sound/soc/fsl/fsl_ssi.c > +++ b/sound/soc/fsl/fsl_ssi.c > @@ -633,7 +633,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, > sub *= 100000; > do_div(sub, freq); > > - if (sub < savesub) { > + if (sub < savesub && !(i == 0 && psr == 0 && div2 == 0)) { > baudrate = tmprate; > savesub = sub; > pm = i; > -- > 2.1.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel