From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755393AbbGCSpW (ORCPT ); Fri, 3 Jul 2015 14:45:22 -0400 Received: from imap.thunk.org ([74.207.234.97]:39113 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755328AbbGCSpQ (ORCPT ); Fri, 3 Jul 2015 14:45:16 -0400 Date: Fri, 3 Jul 2015 14:45:02 -0400 From: "Theodore Ts'o" To: nick Cc: Michal Hocko , akpm@linux-foundation.org, mgorman@suse.de, n-horiguchi@ah.jp.nec.com, sasha.levin@oracle.com, Yalin.Wang@sonymobile.com, jmarchan@redhat.com, kirill@shutemov.name, rientjes@google.com, vbabka@suse.cz, aneesh.kumar@linux.vnet.ibm.com, ebru.akagunduz@gmail.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm:Make the function zap_huge_pmd bool Message-ID: <20150703184501.GJ9456@thunk.org> Mail-Followup-To: Theodore Ts'o , nick , Michal Hocko , akpm@linux-foundation.org, mgorman@suse.de, n-horiguchi@ah.jp.nec.com, sasha.levin@oracle.com, Yalin.Wang@sonymobile.com, jmarchan@redhat.com, kirill@shutemov.name, rientjes@google.com, vbabka@suse.cz, aneesh.kumar@linux.vnet.ibm.com, ebru.akagunduz@gmail.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1435775277-27381-1-git-send-email-xerofoify@gmail.com> <20150702072621.GB12547@dhcp22.suse.cz> <20150702160341.GC9456@thunk.org> <55956204.2060006@gmail.com> <20150703144635.GE9456@thunk.org> <5596A20F.6010509@gmail.com> <20150703150117.GA3688@dhcp22.suse.cz> <5596A42F.60901@gmail.com> <20150703164944.GG9456@thunk.org> <5596BDB6.5060708@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5596BDB6.5060708@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 03, 2015 at 12:52:06PM -0400, nick wrote: > I agree with you 100 percent. The reason I can't test this is I don't have the > hardware otherwise I would have tested it by now. Then don't send the patch out. Work on some other piece of part of the kernel, or better yet, some other userspace code where testing is easier. It's really quite simple. You don't have the technical skills, or at this point, the reputation, to send patches without tesitng them first. The fact that sometimes people like Linus will send out a patch labelled with "COMPLETELY UNTESTED", is because he's skilled and trusted enough that he can get away with it. You have neither of those advantages. Best regards, - Ted