From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario Limonciello <mario_limonciello@dell.com>,
Matthew Garrett <mjg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Len Brown <len.brown@intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Michał Kępień" <kernel@kempniu.pl>
Subject: BUG? Duplicate key code 0xe045 in dell-wmi.c
Date: Sat, 4 Jul 2015 18:34:03 +0200 [thread overview]
Message-ID: <201507041834.03944@pali> (raw)
[-- Attachment #1: Type: Text/Plain, Size: 1377 bytes --]
Hello,
I'm looking at dell-wmi.c driver and its history in git and I found
problem with handling WMI key code 0xe045. In current dell-wmi.c code is
{KE_KEY, 0xe045, KEY_PROG1},
{KE_IGNORE, 0xe045, KEY_NUMLOCK},
I bet this is some copy-paste error as one code can be translated only
to one input key event.
In git history I found that above change was added by commit:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5cab0098171712a9fd51399b06181c8dfdebe9c9
===============================================
commit 5cab0098171712a9fd51399b06181c8dfdebe9c9
Author: Mario Limonciello <mario_limonciello@dell.com>
Date: Wed Jun 10 19:40:47 2009 +0000
dell-wmi: add additional keyboard events
Upcoming Dell hardware will send more keyboard events via WMI. Add
support for them.
Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Len Brown <len.brown@intel.com>
===============================================
Sending email to all signers of this commit. Problematic code is still
in upstream kernel, so it needs to be fixed.
Mario Limonciello: Do you know if code 0xe045 is some PROG1 or NUMLOCK?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2015-07-05 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 16:34 Pali Rohár [this message]
2015-07-07 18:38 ` BUG? Duplicate key code 0xe045 in dell-wmi.c Mario Limonciello
2015-07-07 21:18 ` Pali Rohár
2015-07-20 14:51 ` Pali Rohár
2015-09-04 10:34 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201507041834.03944@pali \
--to=pali.rohar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gabriele.mzt@gmail.com \
--cc=kernel@kempniu.pl \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).