From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arjun Krishna Babu <arjunkrishnababu96@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function
Date: Mon, 6 Jul 2015 10:32:57 +0300 [thread overview]
Message-ID: <20150706073257.GB28762@mwanda> (raw)
In-Reply-To: <1436120188-15368-1-git-send-email-arjunkrishnababu96@gmail.com>
On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Macros with flow control statements should be avoided
>
> Replace the macro with a function doing the exact same task as the
> macro.
>
No. You haven't understood what DGNC_VERIFY_BOARD() does and have you
even tried to compile this? Surely the compiler will complain that some
paths don't have a return value?
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-06 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 18:16 [PATCH] staging: dgnc: Replace macro with flow control statement by a function Arjun Krishna Babu
2015-07-06 7:32 ` Dan Carpenter [this message]
2015-07-06 12:15 ` Ravi Teja Darbha
2015-07-06 12:27 ` Sudip Mukherjee
2015-07-06 13:20 ` Ravi Teja Darbha
2015-07-06 13:28 ` Valdis.Kletnieks
2015-07-06 14:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706073257.GB28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arjunkrishnababu96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox