From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Joe Perches <joe@perches.com>,
driverdev-devel@linuxdriverproject.org,
Mario Bambagini <mario.bambagini@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] defines modified to match the 80-char rule
Date: Mon, 6 Jul 2015 11:30:34 +0300 [thread overview]
Message-ID: <20150706083033.GC28762@mwanda> (raw)
In-Reply-To: <m33811q0nb.fsf@t19.piap.pl>
On Mon, Jul 06, 2015 at 08:07:52AM +0200, Krzysztof Hałasa wrote:
> Joe Perches <joe@perches.com> writes:
>
> > Nah, you're not an extremist, you're just preferring narrowly
> > localized readability over global consistency.
> >
> > That's fine and all, until you come up to LCONSOLE_ERROR_MSG
> > type use which blows the nice old formatting up.
> >
> > So what I suggested is just a simple consistency thing.
>
> So, could we have the localized readability when it makes sense,
> and the default rules when nothing else applies?
It's localized to literally those four lines, the pattern breaks down
for the other six macros.
regards,
dan carpenter
prev parent reply other threads:[~2015-07-06 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 21:21 [PATCH] defines modified to match the 80-char rule Mario Bambagini
2015-07-01 7:59 ` Krzysztof Hałasa
2015-07-02 6:20 ` Joe Perches
2015-07-02 18:01 ` Joe Perches
2015-07-03 10:58 ` Krzysztof Hałasa
2015-07-03 16:10 ` Joe Perches
2015-07-06 6:07 ` Krzysztof Hałasa
2015-07-06 8:07 ` Joe Perches
2015-07-06 12:16 ` Krzysztof Hałasa
2015-07-08 15:30 ` Joe Perches
2015-07-06 8:30 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706083033.GC28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=joe@perches.com \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.bambagini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox