From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753601AbbGFIbM (ORCPT ); Mon, 6 Jul 2015 04:31:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29404 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbbGFIbI (ORCPT ); Mon, 6 Jul 2015 04:31:08 -0400 Date: Mon, 6 Jul 2015 11:30:34 +0300 From: Dan Carpenter To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: Joe Perches , driverdev-devel@linuxdriverproject.org, Mario Bambagini , linux-kernel@vger.kernel.org Subject: Re: [PATCH] defines modified to match the 80-char rule Message-ID: <20150706083033.GC28762@mwanda> References: <1435094481-32275-1-git-send-email-mario.bambagini@gmail.com> <1435818026.2487.5.camel@perches.com> <1435860103.2487.30.camel@perches.com> <1435939832.2487.64.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2015 at 08:07:52AM +0200, Krzysztof Hałasa wrote: > Joe Perches writes: > > > Nah, you're not an extremist, you're just preferring narrowly > > localized readability over global consistency. > > > > That's fine and all, until you come up to LCONSOLE_ERROR_MSG > > type use which blows the nice old formatting up. > > > > So what I suggested is just a simple consistency thing. > > So, could we have the localized readability when it makes sense, > and the default rules when nothing else applies? It's localized to literally those four lines, the pattern breaks down for the other six macros. regards, dan carpenter