From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756198AbbGFNnR (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jul 2015 09:43:17 -0400
Received: from mail.windriver.com ([147.11.1.11]:40523 "EHLO
	mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755032AbbGFNnP convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jul 2015 09:43:15 -0400
Date: Mon, 6 Jul 2015 09:42:47 -0400
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
CC: Geert Uytterhoeven <geert@linux-m68k.org>,
        Chen Gang <xili_gchen_5257@hotmail.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Simon Horman <horms+renesas@verge.net.au>, <cj@linux.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Mikael Starvik <starvik@axis.com>,
        driverdevel <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on
 CLKDEV_LOOKUP
Message-ID: <20150706134247.GD11898@windriver.com>
References: <BLU436-SMTP22481BECF61D5F450A7F0E0B9950@phx.gbl>
 <CAMuHMdXfL4MQkpkPfUWUPXsrQg+aUtHRm-NsJWJz-BmoyvjfFQ@mail.gmail.com>
 <20150706084801.2995face@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <20150706084801.2995face@canb.auug.org.au>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:

> Hi all,
> 
> On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
> > > It needs clk_add_alias() from clk drivers, which is implemented in
> > > "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
> > >
> > > Normally, archs and clk driver its own will decide whether select
> > > CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
> > >
> > > The related error (with allmodconfig under cris for next-20150702):
> > >
> > >   drivers/built-in.o: In function `board_staging_register_clock':
> > >   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
> > >
> > >
> > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > 
> > Fix available for the last 15 days:
> > 
> > https://lkml.org/lkml/2015/6/20/215
> 
> I added Chen's patch to my fixes tree today (only because I couldn't
> easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a
> full mail message from lkml.org?  Or Geert, maybe that is not the best
> place to link to.

I have had reasonable success pulling stuff out of lkml patchworks:

https://patchwork.kernel.org/patch/6651831/

BTW, Chen's patch is missing the OF_IRQ dependency Geert found in
his build coverage; I'd folded that into the v2 above, figuring
that is what he'd desired I do with it.

P.
--

> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au