[PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[Chen Gang]

It needs clk_add_alias() from clk drivers, which is implemented in
"drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.

Normally, archs and clk driver its own will decide whether select
CLKDEV_LOOKUP, and common drivers will decide whether depend on it.

The related error (with allmodconfig under cris for next-20150702):

  drivers/built-in.o: In function `board_staging_register_clock':
  drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 drivers/staging/board/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/board/Kconfig b/drivers/staging/board/Kconfig
index b8ee818..4ff5a79 100644
--- a/drivers/staging/board/Kconfig
+++ b/drivers/staging/board/Kconfig
@@ -1,6 +1,6 @@
 config STAGING_BOARD
 	bool "Staging Board Support"
-	depends on OF_ADDRESS
+	depends on OF_ADDRESS && CLKDEV_LOOKUP
 	help
 	  Select to enable per-board staging support code.
 
-- 
1.9.3

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[Geert Uytterhoeven]

On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
> It needs clk_add_alias() from clk drivers, which is implemented in
> "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
>
> Normally, archs and clk driver its own will decide whether select
> CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
>
> The related error (with allmodconfig under cris for next-20150702):
>
>   drivers/built-in.o: In function `board_staging_register_clock':
>   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Fix available for the last 15 days:

https://lkml.org/lkml/2015/6/20/215

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Hi all,

On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
> > It needs clk_add_alias() from clk drivers, which is implemented in
> > "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
> >
> > Normally, archs and clk driver its own will decide whether select
> > CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
> >
> > The related error (with allmodconfig under cris for next-20150702):
> >
> >   drivers/built-in.o: In function `board_staging_register_clock':
> >   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
> >
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> 
> Fix available for the last 15 days:
> 
> https://lkml.org/lkml/2015/6/20/215

I added Chen's patch to my fixes tree today (only because I couldn't
easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a
full mail message from lkml.org?  Or Geert, maybe that is not the best
place to link to.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[Chen Gang]

On 07/06/2015 06:48 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>
>> On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
>>> It needs clk_add_alias() from clk drivers, which is implemented in
>>> "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
>>>
>>> Normally, archs and clk driver its own will decide whether select
>>> CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
>>>
>>> The related error (with allmodconfig under cris for next-20150702):
>>>
>>>   drivers/built-in.o: In function `board_staging_register_clock':
>>>   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> Fix available for the last 15 days:
>>
>> https://lkml.org/lkml/2015/6/20/215
> 
> I added Chen's patch to my fixes tree today (only because I couldn't
> easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a
> full mail message from lkml.org?  Or Geert, maybe that is not the best
> place to link to.
> 

For me, I still suggest to use Paul's patch (if it is OK, too). He sent
the patch more than 10 days, and was still waiting patiently.

There will be a little more work, but I guess, it is necessary.

And I shall try to send another patches for Linux kernel. :-)

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[Paul Gortmaker]

[Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:

> Hi all,
> 
> On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
> > > It needs clk_add_alias() from clk drivers, which is implemented in
> > > "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
> > >
> > > Normally, archs and clk driver its own will decide whether select
> > > CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
> > >
> > > The related error (with allmodconfig under cris for next-20150702):
> > >
> > >   drivers/built-in.o: In function `board_staging_register_clock':
> > >   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
> > >
> > >
> > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > 
> > Fix available for the last 15 days:
> > 
> > https://lkml.org/lkml/2015/6/20/215
> 
> I added Chen's patch to my fixes tree today (only because I couldn't
> easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a
> full mail message from lkml.org?  Or Geert, maybe that is not the best
> place to link to.

I have had reasonable success pulling stuff out of lkml patchworks:

https://patchwork.kernel.org/patch/6651831/

BTW, Chen's patch is missing the OF_IRQ dependency Geert found in
his build coverage; I'd folded that into the v2 above, figuring
that is what he'd desired I do with it.

P.
--

> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[Geert Uytterhoeven]

Hi Paul,

On Mon, Jul 6, 2015 at 3:42 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> BTW, Chen's patch is missing the OF_IRQ dependency Geert found in
> his build coverage; I'd folded that into the v2 above, figuring
> that is what he'd desired I do with it.

Which I'm very grateful for. Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1909 bytes --]

Hi Paul,

On Mon, 6 Jul 2015 09:42:47 -0400 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> [Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:
> 
> > On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > >
> > > On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
> > > > It needs clk_add_alias() from clk drivers, which is implemented in
> > > > "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
> > > >
> > > > Normally, archs and clk driver its own will decide whether select
> > > > CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
> > > >
> > > > The related error (with allmodconfig under cris for next-20150702):
> > > >
> > > >   drivers/built-in.o: In function `board_staging_register_clock':
> > > >   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
> > > >
> > > >
> > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > > 
> > > Fix available for the last 15 days:
> > > 
> > > https://lkml.org/lkml/2015/6/20/215
> > 
> > I added Chen's patch to my fixes tree today (only because I couldn't
> > easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a
> > full mail message from lkml.org?  Or Geert, maybe that is not the best
> > place to link to.
> 
> I have had reasonable success pulling stuff out of lkml patchworks:
> 
> https://patchwork.kernel.org/patch/6651831/
> 
> BTW, Chen's patch is missing the OF_IRQ dependency Geert found in
> his build coverage; I'd folded that into the v2 above, figuring
> that is what he'd desired I do with it.

I have replaced Chen's patch with your patch in my fixes tree ...
hopefully it won;t need to be there long.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]