From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754376AbbGFQj6 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jul 2015 12:39:58 -0400
Received: from mail-wg0-f42.google.com ([74.125.82.42]:36617 "EHLO
	mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751644AbbGFQjz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jul 2015 12:39:55 -0400
Date: Mon, 6 Jul 2015 18:39:50 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        Aubrey Li <aubrey.li@linux.intel.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "Kumar P, Mahesh" <mahesh.kumar.p@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] x86: pmc_atom: Add Cherrytrail PMC interface
Message-ID: <20150706163950.GA22751@gmail.com>
References: <1436192944-56496-1-git-send-email-andriy.shevchenko@linux.intel.com>
 <1436192944-56496-5-git-send-email-andriy.shevchenko@linux.intel.com>
 <20150706154425.GA19665@gmail.com>
 <alpine.DEB.2.11.1507061747100.3916@nanos>
 <20150706155008.GA3095@gmail.com>
 <CAHp75VfupS4FLu2jAmBL-Ja-ydb9+0-thD3pUbwrD+3StrE4dA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VfupS4FLu2jAmBL-Ja-ydb9+0-thD3pUbwrD+3StrE4dA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Mon, Jul 6, 2015 at 6:50 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> >> On Mon, 6 Jul 2015, Ingo Molnar wrote:
> >>
> >> > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >> >
> >> > > The patch adds CHT PMC interface. This exposes all the South IP device power
> >> > > states and S0ix states for CHT. The bit map of FUNC_DIS and D3_STS_0 registers
> >> > > for SoCs are consistent. The D3_STS_1 and FUNC_DIS_2 registers, however, are
> >> > > not aligned. This is fixed by splitting a common mapping on per register basis.
> >> > >
> >> > > Signed-off-by: Kumar P Mahesh <mahesh.kumar.p@intel.com>
> >> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> >
> >> > That's a weird signoff sequence. I changed it to:
> >> >
> >> >  Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> >  Acked-by: Kumar P Mahesh <mahesh.kumar.p@intel.com>
> >>
> >> It might lack a From: Kumar ...
> >
> > Yeah, and got lost due to a rebase. Will change it to that, to preserve
> > authorship. Won't push it out before I hear back from Andy though.
> 
> To clarify: "It's based on the previous work done by Kumar P Mahesh."
> and we can remove SoB. It's quite far from the code initially taken
> from Kumar.
> 
> Would you like me to update the commit message accordingly?

Ok.

Thanks,

	Ingo