From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756210AbbGFUiW (ORCPT ); Mon, 6 Jul 2015 16:38:22 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59256 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755238AbbGFUiN (ORCPT ); Mon, 6 Jul 2015 16:38:13 -0400 Date: Mon, 6 Jul 2015 22:38:11 +0200 From: Alexandre Belloni To: Stephen Boyd Cc: Mike Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Boris BREZILLON Subject: Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage Message-ID: <20150706203811.GC3127@piout.net> References: <1436211105-10491-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436211105-10491-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 06/07/2015 at 12:31:45 -0700, Stephen Boyd wrote : > Remove useless ifdefs around function prototypes to silence the > following sparse warnings when the configs aren't enabled. > > drivers/clk/at91/clk-h32mx.c:95:13: warning: symbol > 'of_sama5d4_clk_h32mx_setup' was not declared. Should it be > static? > drivers/clk/at91/clk-utmi.c:159:13: warning: symbol > 'of_at91sam9x5_clk_utmi_setup' was not declared. Should it be > static? > > Plus, using __init in function prototypes doesn't do anything, so > just drop it throughout this file. > The main drawback of that removal is that it destroys the alignment throughout the header file :) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com