* [PATCH] input: misc: bma150: use sign_extend32() for sign extending
@ 2015-07-02 23:13 Martin Kepplinger
2015-07-06 22:52 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2015-07-02 23:13 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Martin Kepplinger
Despite it's name, sign_extend32() is used for 16 bit values aswell.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/input/misc/bma150.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
index b36831c..c278049 100644
--- a/drivers/input/misc/bma150.c
+++ b/drivers/input/misc/bma150.c
@@ -333,10 +333,9 @@ static void bma150_report_xyz(struct bma150_data *bma150)
y = ((0xc0 & data[2]) >> 6) | (data[3] << 2);
z = ((0xc0 & data[4]) >> 6) | (data[5] << 2);
- /* sign extension */
- x = (s16) (x << 6) >> 6;
- y = (s16) (y << 6) >> 6;
- z = (s16) (z << 6) >> 6;
+ x = sign_extend32(x, 9);
+ y = sign_extend32(y, 9);
+ z = sign_extend32(z, 9);
input_report_abs(bma150->input, ABS_X, x);
input_report_abs(bma150->input, ABS_Y, y);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: misc: bma150: use sign_extend32() for sign extending
2015-07-02 23:13 [PATCH] input: misc: bma150: use sign_extend32() for sign extending Martin Kepplinger
@ 2015-07-06 22:52 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-07-06 22:52 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: linux-input, linux-kernel
On Fri, Jul 03, 2015 at 01:13:01AM +0200, Martin Kepplinger wrote:
> Despite it's name, sign_extend32() is used for 16 bit values aswell.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Applied, thank you.
> ---
> drivers/input/misc/bma150.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
> index b36831c..c278049 100644
> --- a/drivers/input/misc/bma150.c
> +++ b/drivers/input/misc/bma150.c
> @@ -333,10 +333,9 @@ static void bma150_report_xyz(struct bma150_data *bma150)
> y = ((0xc0 & data[2]) >> 6) | (data[3] << 2);
> z = ((0xc0 & data[4]) >> 6) | (data[5] << 2);
>
> - /* sign extension */
> - x = (s16) (x << 6) >> 6;
> - y = (s16) (y << 6) >> 6;
> - z = (s16) (z << 6) >> 6;
> + x = sign_extend32(x, 9);
> + y = sign_extend32(y, 9);
> + z = sign_extend32(z, 9);
>
> input_report_abs(bma150->input, ABS_X, x);
> input_report_abs(bma150->input, ABS_Y, y);
> --
> 2.1.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-06 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-02 23:13 [PATCH] input: misc: bma150: use sign_extend32() for sign extending Martin Kepplinger
2015-07-06 22:52 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox