From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbbGGEAn (ORCPT ); Tue, 7 Jul 2015 00:00:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38595 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbbGGEAd (ORCPT ); Tue, 7 Jul 2015 00:00:33 -0400 Date: Mon, 6 Jul 2015 19:06:35 -0700 From: Greg KH To: Kris Borer Cc: stern@rowland.harvard.edu, balbi@ti.com, pmladek@suse.cz, antoine.tenart@free-electrons.com, hdegoede@redhat.com, sergei.shtylyov@cogentembedded.com, rafael.j.wysocki@intel.com, mickael.maison@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: move assignment out of if condition Message-ID: <20150707020635.GA5432@kroah.com> References: <1435875839-4680-1-git-send-email-kborer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435875839-4680-1-git-send-email-kborer@gmail.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 02, 2015 at 06:23:59PM -0400, Kris Borer wrote: > Fix four occurrences of checkpatch.pl error: > > ERROR: do not use assignment in if condition > > Signed-off-by: Kris Borer > --- > drivers/usb/core/hcd.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) Again, please use Coccinelle for something like this, otherwise I'm not going to trust that it is correct :) thanks, greg k-h