From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753571AbbGGD4t (ORCPT ); Mon, 6 Jul 2015 23:56:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:54836 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbGGD4n (ORCPT ); Mon, 6 Jul 2015 23:56:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,419,1432623600"; d="scan'208";a="601325477" Date: Tue, 7 Jul 2015 09:28:25 +0530 From: Vinod Koul To: Krzysztof Kozlowski Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , stable@vger.kernel.org Subject: Re: [PATCH] dmaengine: pl330: Fix overflow when reporting residue in memcpy Message-ID: <20150707035825.GE11002@localhost> References: <1434356716-32726-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434356716-32726-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2015 at 05:25:16PM +0900, Krzysztof Kozlowski wrote: > During memcpy operations the residue was always set to an u32 overflowed > value. > > In pl330_tx_status() function number of currently transferred bytes was > subtracted from internal "bytes_requested" field. However this > "bytes_requested" was not initialized at start to length of memcpy > buffer so transferred bytes were subtracted from 0 causing overflow. Applied, thanks -- ~Vinod