From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940AbbGGGsE (ORCPT ); Tue, 7 Jul 2015 02:48:04 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:33715 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbbGGGr7 (ORCPT ); Tue, 7 Jul 2015 02:47:59 -0400 Date: Tue, 7 Jul 2015 07:47:55 +0100 From: Lee Jones To: Axel Lin Cc: Mike Rapoport , Alban Bedel , Stefan Agner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: tps6586x: Fix up define for TPS6586X_MAX_REGISTER Message-ID: <20150707064755.GD3182@x1> References: <1436230326.10336.0.camel@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1436230326.10336.0.camel@ingics.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jul 2015, Axel Lin wrote: > The latest valid register is TPS6586X_VERSIONCRC. > > Signed-off-by: Axel Lin > --- > drivers/mfd/tps6586x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c > index e0a2583..ae08b29 100644 > --- a/drivers/mfd/tps6586x.c > +++ b/drivers/mfd/tps6586x.c > @@ -52,7 +52,7 @@ > #define TPS6586X_VERSIONCRC 0xcd > > /* Maximum register */ > -#define TPS6586X_MAX_REGISTER (TPS6586X_VERSIONCRC + 1) > +#define TPS6586X_MAX_REGISTER TPS6586X_VERSIONCRC > > struct tps6586x_irq_data { > u8 mask_reg; > @@ -467,7 +467,7 @@ static bool is_volatile_reg(struct device *dev, unsigned int reg) > static const struct regmap_config tps6586x_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > - .max_register = TPS6586X_MAX_REGISTER - 1, > + .max_register = TPS6586X_MAX_REGISTER, > .volatile_reg = is_volatile_reg, > .cache_type = REGCACHE_RBTREE, > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog