From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756859AbbGGKmB (ORCPT ); Tue, 7 Jul 2015 06:42:01 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:37888 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753967AbbGGKlx (ORCPT ); Tue, 7 Jul 2015 06:41:53 -0400 Date: Tue, 7 Jul 2015 12:41:50 +0200 From: Pavel Machek To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Sebastian Reichel , Tony Lindgren , Ivaylo Dimitrov , Aaro Koskinen , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: rx51-battery.ko incompatiblity: board code vs DT Message-ID: <20150707104150.GC13811@amd> References: <201507062144.22911@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201507062144.22911@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2015-07-06 21:44:22, Pali Rohár wrote: > Hello, > > now I found out that rx51-battery.ko driver register sysnode > /sys/class/power_supply/rx51-battery/ when booting with legacy board > code. But when booting DT kernel it register sysnode with different name > /sys/class/power_supply/n900-battery/ > > Sysfs node for DT kernel comes from Nokia N900 DTS file: > arch/arm/boot/dts/omap3-n900.dts > > I would propose change which change DTS to "rx51-battery" to have it > compatible with naming which is for legacy board code. It is just > because to have compatibility and same naming scheme and also to make > existing programs to work without needing patching them. > > What do you think? Makes sense.. along with _big_ comment in the dts why we are doing this. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html