From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: wm8994-regmap: Constify reg_default tables
Date: Tue, 7 Jul 2015 13:46:54 +0100 [thread overview]
Message-ID: <20150707124654.GC3182@x1> (raw)
In-Reply-To: <1436267459.6600.1.camel@ingics.com>
On Tue, 07 Jul 2015, Axel Lin wrote:
> These reg_default tables are not modified after initialized, so make them
> const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/wm8994-regmap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c
> index 300e9b6..c56b160 100644
> --- a/drivers/mfd/wm8994-regmap.c
> +++ b/drivers/mfd/wm8994-regmap.c
> @@ -19,7 +19,7 @@
>
> #include "wm8994.h"
>
> -static struct reg_default wm1811_defaults[] = {
> +static const struct reg_default wm1811_defaults[] = {
> { 0x0001, 0x0000 }, /* R1 - Power Management (1) */
> { 0x0002, 0x6000 }, /* R2 - Power Management (2) */
> { 0x0003, 0x0000 }, /* R3 - Power Management (3) */
> @@ -251,7 +251,7 @@ static struct reg_default wm1811_defaults[] = {
> { 0x0748, 0x003F }, /* R1864 - IRQ Debounce */
> };
>
> -static struct reg_default wm8994_defaults[] = {
> +static const struct reg_default wm8994_defaults[] = {
> { 0x0001, 0x0000 }, /* R1 - Power Management (1) */
> { 0x0002, 0x6000 }, /* R2 - Power Management (2) */
> { 0x0003, 0x0000 }, /* R3 - Power Management (3) */
> @@ -470,7 +470,7 @@ static struct reg_default wm8994_defaults[] = {
> { 0x0748, 0x003F }, /* R1864 - IRQ Debounce */
> };
>
> -static struct reg_default wm8958_defaults[] = {
> +static const struct reg_default wm8958_defaults[] = {
> { 0x0001, 0x0000 }, /* R1 - Power Management (1) */
> { 0x0002, 0x6000 }, /* R2 - Power Management (2) */
> { 0x0003, 0x0000 }, /* R3 - Power Management (3) */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-07-07 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 11:10 [PATCH] mfd: wm8994-regmap: Constify reg_default tables Axel Lin
2015-07-07 12:06 ` Charles Keepax
2015-07-07 12:46 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707124654.GC3182@x1 \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox