From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757480AbbGGNrU (ORCPT ); Tue, 7 Jul 2015 09:47:20 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:34536 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757276AbbGGNpu (ORCPT ); Tue, 7 Jul 2015 09:45:50 -0400 Date: Tue, 7 Jul 2015 14:45:45 +0100 From: Lee Jones To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, lgirdwood@gmail.com Subject: Re: [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage Message-ID: <20150707134545.GH3182@x1> References: <1436173112-21397-1-git-send-email-lee.jones@linaro.org> <1436173112-21397-9-git-send-email-lee.jones@linaro.org> <20150707133155.GL2887@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150707133155.GL2887@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jul 2015, Mark Brown wrote: > On Mon, Jul 06, 2015 at 09:58:30AM +0100, Lee Jones wrote: > > > + tmp = max_duty_cycle - min_mV * max_duty_cycle / vdiff; > > + pwm_code = tmp + max_duty_cycle * volt_mV / vdiff; > > These need some brackets to be clear that they're correct. As you rightly pointed out, this stuff gets over-written in the next patch, although I have no problem with providing some bracketing if required. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog