From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757558AbbGGNuo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jul 2015 09:50:44 -0400
Received: from mail.kernel.org ([198.145.29.136]:43386 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757286AbbGGNuf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jul 2015 09:50:35 -0400
Date: Tue, 7 Jul 2015 10:50:31 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Andi Kleen <ak@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Jiri Olsa <jolsa@redhat.com>, Stephane Eranian <eranian@google.com>,
        mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH V3 2/4] perf tools: Add new PERF_RECORD_SWITCH event
Message-ID: <20150707135031.GD3326@kernel.org>
References: <1436258202-6540-1-git-send-email-adrian.hunter@intel.com>
 <1436258202-6540-3-git-send-email-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436258202-6540-3-git-send-email-adrian.hunter@intel.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Jul 07, 2015 at 11:36:40AM +0300, Adrian Hunter escreveu:
> +size_t perf_event__fprintf_switch(union perf_event *event, FILE *fp)
> +{
> +	bool out = event->header.misc & PERF_RECORD_MISC_SWITCH_OUT;
> +	const char *in_out = out ? "OUT" : "IN ";
> +
> +	if (event->context_switch.next_prev_pid == (u32)-1)

I.e. we would have the test:

	if (!(event->header.misc & PERF_RECORD_MISC_SWITCH_NEXT_PREV_PID))
		return fprintf(fp, " %s\n", in_out);

> +	return fprintf(fp, " %s  %s pid/tid: %5u/%-5u\n",
> +		       in_out, out ? "next" : "prev",
> +		       event->context_switch.next_prev_pid,
> +		       event->context_switch.next_prev_tid);


<SNIP>

> +static void perf_event__switch_swap(union perf_event *event, bool sample_id_all)
> +{

Here too:

	if (event->header.misc & PERF_RECORD_MISC_SWITCH_NEXT_PREV_PID) {
		event->context_switch.next_prev_pid = bswap_32(event->context_switch.next_prev_pid);
		event->context_switch.next_prev_tid = bswap_32(event->context_switch.next_prev_tid);
		if (sample_id_all)
			swap_sample_id_all(event, &event->context_switch + 1);
	} else if (sample_id_all)
		swap_sample_id_all(event, &event->header + 1);
> +}
> +