public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	Michael Turquette <mturquette@baylibre.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Query: Clock driver requests mailbox channel
Date: Tue, 7 Jul 2015 22:04:25 +0800	[thread overview]
Message-ID: <20150707140424.GA12992@leoy-linaro> (raw)
In-Reply-To: <CABb+yY1qjq_uXTb-S4GO7rugs1Wa9j_VpSb3=0rq1Zv+-t+u2Q@mail.gmail.com>

On Tue, Jul 07, 2015 at 10:54:55AM +0530, Jassi Brar wrote:
> On Mon, Jul 6, 2015 at 5:03 PM, Leo Yan <leo.yan@linaro.org> wrote:
> > Hi all,
> >
> > i'm working with one clock driver, which will invoke mailbox API to
> > request the mailbox channel and send message.
> >
> > Usually clock driver will init with devicetree, below is the example:
> > CLK_OF_DECLARE(hi6220_clk_power, "hisilicon,hi6220-clock-power",
> > hi6220_clk_power_init);
> >
> > Clock init function it will pass the pointer of struct device_node
> > but not the pointer of struct device. So finally it's difficult to
> > invoke mailbox API *mbox_request_channel()*, due it need use the
> > struct device to search DT's property "mboxes".
> >
> > I want to find which is the best way to resolve this issue, so do you
> > suggest clock driver to manually register one device? Or can we add
> > one more API to request the mailbox channel directly with device_node?
> >
> IIUC, such clocks (that require platform resources) should be
> populated from the platform_device's probe()?

Thanks for response, Jassi. If we use general platform_device's probe()
function, then we can smoothly to get device poiner.

But if we use the method with CLK_OF_DECLARE, then i tried to get device
pointer with the function of_find_device_by_node(), it will return the
device pointer is NULL. But this is the common case in many clock drivers.

So i just wander if can provide another mailbox API for this case,
which will only need to pass device node pointer?

Thanks,
Leo Yan

  reply	other threads:[~2015-07-07 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 11:33 Query: Clock driver requests mailbox channel Leo Yan
2015-07-07  5:24 ` Jassi Brar
2015-07-07 14:04   ` Leo Yan [this message]
2015-07-08 16:54     ` Michael Turquette
2015-07-10  6:08       ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707140424.GA12992@leoy-linaro \
    --to=leo.yan@linaro.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox