From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756990AbbGGOWT (ORCPT ); Tue, 7 Jul 2015 10:22:19 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:34969 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757187AbbGGOV5 (ORCPT ); Tue, 7 Jul 2015 10:21:57 -0400 Date: Tue, 7 Jul 2015 23:21:09 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v6 6/7] zsmalloc: account the number of compacted pages Message-ID: <20150707142109.GA1450@swordfish> References: <1436270221-17844-1-git-send-email-sergey.senozhatsky@gmail.com> <1436270221-17844-7-git-send-email-sergey.senozhatsky@gmail.com> <20150707133916.GC3898@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150707133916.GC3898@blaptop> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/07/15 22:39), Minchan Kim wrote: [..] > > struct zs_pool_stats { > > - /* How many objects were migrated */ > > - u64 num_migrated; > > + /* How many pages were migrated (freed) */ > > + u64 pages_compacted; > > Hmm, if we account it as page unit, unsigned long is enough for 32bit. Well, this is a 'how many pages were freed overall' counter. We don't control the lifetime of device, so I think it can be bigger than 4 bytes in some `extreme' cases. -ss