From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757582AbbGGO3w (ORCPT ); Tue, 7 Jul 2015 10:29:52 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:38722 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757341AbbGGO3Z (ORCPT ); Tue, 7 Jul 2015 10:29:25 -0400 Date: Tue, 7 Jul 2015 15:29:21 +0100 From: Lee Jones To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, lgirdwood@gmail.com Subject: Re: [RESEND 09/10] regulator: pwm-regulator: Simplify voltage to duty-cycle call Message-ID: <20150707142921.GI3182@x1> References: <1436173112-21397-1-git-send-email-lee.jones@linaro.org> <1436173112-21397-10-git-send-email-lee.jones@linaro.org> <20150707133245.GM2887@sirena.org.uk> <20150707134503.GG3182@x1> <20150707135256.GQ2887@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150707135256.GQ2887@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jul 2015, Mark Brown wrote: > On Tue, Jul 07, 2015 at 02:45:03PM +0100, Lee Jones wrote: > > On Tue, 07 Jul 2015, Mark Brown wrote: > > > > You just added this function in the previous patch? > > > You're right, it does look a little weird contained in a single > > patch-set. The submission in the previous patch is the tried and > > tested (i.e. in real releases) method written by ST. This patch > > contains a simplification provided by me. IMO it looks and performs > > better, but doesn't have the same time-under-test that the original > > method does. I'm merely ensuring we keep some history in order so > > provide and easy way back i.e. revert. > > > If I have any say at all, I'd really like to keep this piece of > > history. > > OK, that makes sense - can you put the above in the commit message > please? Sure. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog