From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757187AbbGGOmI (ORCPT ); Tue, 7 Jul 2015 10:42:08 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34919 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683AbbGGOlz (ORCPT ); Tue, 7 Jul 2015 10:41:55 -0400 Date: Tue, 7 Jul 2015 23:41:07 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v6 7/7] zsmalloc: use shrinker to trigger auto-compaction Message-ID: <20150707144107.GC1450@swordfish> References: <1436270221-17844-1-git-send-email-sergey.senozhatsky@gmail.com> <1436270221-17844-8-git-send-email-sergey.senozhatsky@gmail.com> <20150707134445.GD3898@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150707134445.GD3898@blaptop> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/07/15 22:44), Minchan Kim wrote: [..] > IMO, there is no value to maintain just in case of > failing register_shrinker in practice. > > Let's remove shrinker_enabled and abort pool creation if shrinker register > is failed. But why would we do this? Yes, it's kinda-sorta bad -- we were not able to register zspool shrinker, so there will be no automatic compaction... And that's it. It does not affect zsmalloc/zram functionality by any means. Including compaction itself -- user still has a way to compact zspool (manually). And in some scenarios user will never even see automatic compaction in action (assuming that there is a plenty of RAM available). Can you explain your decision? -ss