From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932364AbbGGPC5 (ORCPT ); Tue, 7 Jul 2015 11:02:57 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20808 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182AbbGGPCt (ORCPT ); Tue, 7 Jul 2015 11:02:49 -0400 Date: Tue, 7 Jul 2015 18:01:57 +0300 From: Dan Carpenter To: Robert Baldyga Cc: gregkh@linuxfoundation.org, balbi@ti.com, devel@driverdev.osuosl.org, hamohammed.sa@gmail.com, chris@rorvick.com, tapaswenipathak@gmail.com, linux-usb@vger.kernel.org, nicolas.ferre@atmel.com, hgujulan@visteon.com, mina86@mina86.com, linux-kernel@vger.kernel.org, vinc94@gmail.com, roberta.dobrescu@gmail.com, andrzej.p@samsung.com, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: Re: [PATCH 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit() Message-ID: <20150707150156.GE4341@mwanda> References: <1436277773-14274-1-git-send-email-r.baldyga@samsung.com> <1436277773-14274-4-git-send-email-r.baldyga@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436277773-14274-4-git-send-email-r.baldyga@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07, 2015 at 04:02:51PM +0200, Robert Baldyga wrote: > Should use usb_ep_set_maxpacket_limit instead of setting > maxpacket value manually. > This is a behavior change, right, since now we're setting ep->ep.maxpacket and ep->ep.maxpacket_limit where before we only set the first. I don't understand. This patch description is not clear. regards, dan carpenter > Signed-off-by: Robert Baldyga > --- > drivers/usb/isp1760/isp1760-udc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c > index 18ebf5b1..3699962 100644 > --- a/drivers/usb/isp1760/isp1760-udc.c > +++ b/drivers/usb/isp1760/isp1760-udc.c > @@ -1382,11 +1382,11 @@ static void isp1760_udc_init_eps(struct isp1760_udc *udc) > * This fits in the 8kB FIFO without double-buffering. > */ > if (ep_num == 0) { > - ep->ep.maxpacket = 64; > + usb_ep_set_maxpacket_limit(&ep->ep, 64); > ep->maxpacket = 64; > udc->gadget.ep0 = &ep->ep; > } else { > - ep->ep.maxpacket = 512; > + usb_ep_set_maxpacket_limit(&ep->ep, 512); > ep->maxpacket = 0; > list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list); > }