From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: ast@plumgrid.com, brendan.d.gregg@gmail.com,
daniel@iogearbox.net, Namhyung Kim <namhyung@kernel.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org, lizefan@huawei.com,
hekuang@huawei.com, xiakaixu@huawei.com, pi3orama@163.com
Subject: Re: [RFC PATCH v10 23/50] perf tools: Make perf depend on libbpf
Date: Tue, 7 Jul 2015 17:16:56 -0300 [thread overview]
Message-ID: <20150707201656.GE3135@kernel.org> (raw)
In-Reply-To: <20150707195452.GD3135@kernel.org>
Em Tue, Jul 07, 2015 at 04:54:52PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Jul 01, 2015 at 02:14:11AM +0000, Wang Nan escreveu:
> > By adding libbpf into perf's Makefile, this patch enables perf to
> > build libbpf during building if libelf is found and neither NO_LIBELF
> > nor NO_LIBBPF is set. The newly introduced code is similar to libapi
> > and libtraceevent building in Makefile.perf.
> > MANIFEST is also updated for 'make perf-*-src-pkg'.
> > Append make_no_libbpf to tools/perf/tests/make.
> > 'bpf' feature check is appended into default FEATURE_TESTS and
> > FEATURE_DISPLAY, so perf will check API version of bpf in
> > /path/to/kernel/include/uapi/linux/bpf.h. Which should not fail
> > except when we are trying to port this code to an old kernel.
> >
> > Error messages are also updated to notify users about the disable of
> > BPF support of 'perf record' if libelf is missed or BPF API check
> > failed.
>
> Much better!
<SNIP>
> Auto-detecting system features:
<SNIP>
> ... bpf: [ on ]
<SNIP>
But... I was all happy about this being linked with perf, went straight
ahead to try to use it! No, its not possible, I have to go thru a series
of other patches first... anticlimactic :-(
So, please move this to just before we can use it, wiring it up should
mean, hey, try this "hello, world" eBPF program right now!
And please consider using the patches in the tmp.perf/ebpf branch in my
tree, the code contents are the same as yours, but I did some changes to
the comment texts, fixing some typos, etc.
Also I fixed up the first two patches, the ones for the kernel, as it
was conflicting with some patches, including one where Steven Rostedt
renamed some trace_events structs and file names, that previously had
"ftrace" in it.
Also next time please leave all this in a git branch I can try, to be
able to try the end result, doing that may help me while doing the next
review.
I'll have to stop for today, will try as soon as you address the
comments to go back working on this.
Thanks!
- Arnaldo
next prev parent reply other threads:[~2015-07-07 20:17 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 2:13 [RFC PATCH v10 00/50] perf tools: filtering events using eBPF programs Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 01/50] bpf: Use correct #ifdef controller for trace_call_bpf() Wang Nan
2015-08-07 7:15 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 02/50] tracing, perf: Implement BPF programs attached to uprobes Wang Nan
2015-08-07 7:16 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 03/50] bpf tools: Introduce 'bpf' library and add bpf feature check Wang Nan
2015-08-08 8:09 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 04/50] bpf tools: Allow caller to set printing function Wang Nan
2015-08-08 8:09 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 05/50] bpf tools: Open eBPF object file and do basic validation Wang Nan
2015-08-08 8:10 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 06/50] bpf tools: Read eBPF object from buffer Wang Nan
2015-08-08 8:10 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 07/50] bpf tools: Check endianness and make libbpf fail early Wang Nan
2015-08-08 8:10 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 08/50] bpf tools: Iterate over ELF sections to collect information Wang Nan
2015-08-08 8:11 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 09/50] bpf tools: Collect version and license from ELF sections Wang Nan
2015-08-08 8:11 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 10/50] bpf tools: Collect map definitions from 'maps' section Wang Nan
2015-08-08 8:11 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:13 ` [RFC PATCH v10 11/50] bpf tools: Collect symbol table from SHT_SYMTAB section Wang Nan
2015-07-07 15:10 ` Arnaldo Carvalho de Melo
2015-08-08 8:12 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 12/50] bpf tools: Collect eBPF programs from their own sections Wang Nan
2015-07-07 15:17 ` Arnaldo Carvalho de Melo
2015-08-08 8:12 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 13/50] bpf tools: Collect relocation sections from SHT_REL sections Wang Nan
2015-08-08 8:12 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 14/50] bpf tools: Record map accessing instructions for each program Wang Nan
2015-08-08 8:13 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 15/50] bpf tools: Add bpf.c/h for common bpf operations Wang Nan
2015-08-08 8:13 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 16/50] bpf tools: Create eBPF maps defined in an object file Wang Nan
2015-08-08 8:14 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 17/50] bpf tools: Relocate eBPF programs Wang Nan
2015-08-08 8:14 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 18/50] bpf tools: Introduce bpf_load_program() to bpf.c Wang Nan
2015-08-08 8:14 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 19/50] bpf tools: Load eBPF programs in object files into kernel Wang Nan
2015-08-08 8:15 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 20/50] bpf tools: Introduce accessors for struct bpf_program Wang Nan
2015-07-07 19:37 ` Arnaldo Carvalho de Melo
2015-08-08 8:15 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 21/50] bpf tools: Introduce accessors for struct bpf_object Wang Nan
2015-07-07 19:39 ` Arnaldo Carvalho de Melo
2015-07-01 2:14 ` [RFC PATCH v10 22/50] bpf tools: Link all bpf objects onto a list Wang Nan
2015-07-07 19:47 ` Arnaldo Carvalho de Melo
2015-08-08 8:15 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 23/50] perf tools: Make perf depend on libbpf Wang Nan
2015-07-07 19:54 ` Arnaldo Carvalho de Melo
2015-07-07 20:16 ` Arnaldo Carvalho de Melo [this message]
2015-07-08 2:03 ` Alexei Starovoitov
2015-07-08 13:03 ` Arnaldo Carvalho de Melo
2015-07-08 11:45 ` Wangnan (F)
2015-07-08 13:02 ` Arnaldo Carvalho de Melo
2015-07-01 2:14 ` [RFC PATCH v10 24/50] perf tools: Introduce llvm config options Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 25/50] perf tools: Call clang to compile C source to object code Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 26/50] perf tests: Add LLVM test for eBPF on-the-fly compiling Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 27/50] perf tools: Auto detecting kernel build directory Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 28/50] perf tools: Auto detecting kernel include options Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 29/50] perf record: Enable passing bpf object file to --event Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 30/50] perf record: Compile scriptlets if pass '.c' " Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 31/50] perf tools: Parse probe points of eBPF programs during preparation Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 32/50] perf probe: Attach trace_probe_event with perf_probe_event Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 33/50] perf record: Probe at kprobe points Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 34/50] perf record: Load all eBPF object into kernel Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 35/50] perf tools: Add bpf_fd field to evsel and config it Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 36/50] perf tools: Attach eBPF program to perf event Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 37/50] perf tools: Suppress probing messages when probing by BPF loading Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 38/50] perf record: Add clang options for compiling BPF scripts Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 39/50] bpf tools: Load a program with different instance using preprocessor Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 40/50] perf tools: Fix probe-event.h include Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 41/50] perf probe: Reset tev->args and tev->nargs when failure Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 42/50] perf tools: Move linux/filter.h to tools/include Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 43/50] perf tools: Add BPF_PROLOGUE config options for further patches Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 44/50] perf tools: Introduce arch_get_reg_info() for x86 Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 45/50] perf tools: Add prologue for BPF programs for fetching arguments Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 46/50] perf tools: Generate prologue for BPF programs Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 47/50] perf tools: Use same BPF program if arguments are identical Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 48/50] perf record: Support custom vmlinux path Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 49/50] perf probe: Init symbol as kprobe if any event is kprobe Wang Nan
2015-07-01 2:14 ` [RFC PATCH v10 50/50] perf tools: Support attach BPF program on uprobe events Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707201656.GE3135@kernel.org \
--to=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=brendan.d.gregg@gmail.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).