From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933208AbbGGWsN (ORCPT ); Tue, 7 Jul 2015 18:48:13 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38697 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195AbbGGWsC (ORCPT ); Tue, 7 Jul 2015 18:48:02 -0400 Date: Wed, 8 Jul 2015 00:47:40 +0200 From: Peter Zijlstra To: He Kuang Cc: rostedt@goodmis.org, ast@plumgrid.com, masami.hiramatsu.pt@hitachi.com, acme@kernel.org, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 1/2] tracing: Add new trace type for bpf data output Message-ID: <20150707224740.GV3644@twins.programming.kicks-ass.net> References: <1436269386-72037-1-git-send-email-hekuang@huawei.com> <1436269386-72037-2-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436269386-72037-2-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07, 2015 at 11:43:05AM +0000, He Kuang wrote: > +FTRACE_ENTRY_REG(bpf, trace_bpf, > + > + TRACE_BPF, > + > + F_STRUCT( > + __field(long, size) I would suggest using either u32 or u64, not a variable size type like long. > + __array(u64, raw_data, TRACE_BPF_MAX_ENTRY) > + ), > + > + F_printk("%ld: (%016llx, ...)", __entry->size, __entry->raw_data[0]), > + > + FILTER_OTHER, > + > + perf_ftrace_event_register > +); > -- > 1.8.5.2 >