From: Sreenath Madasu <sreenath.madasu@gmail.com>
To: Valdis.Kletnieks@vt.edu
Cc: jteki@openedev.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c
Date: Tue, 7 Jul 2015 21:08:10 -0400 [thread overview]
Message-ID: <20150708010810.GA2563@sreenath-gentoo.lan> (raw)
In-Reply-To: <15662.1436297570@turing-police.cc.vt.edu>
The kernelnewbies.org guide said "For your first patch, only pick one
warning". That is the reason why I fixed one warning.
Thanks
Sreenath
On Tue, Jul 07, 2015 at 03:32:50PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said:
> > When the checkpatch.pl script was run, it showed lines with length
> > more than 80 characters in rtw_ap.c file. Fixed line number 382 by
> > breaking it up into two lines within 80 characters.
>
>
> > - stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
> > + stainfo_offset =
> > + rtw_stainfo_offset(pstapriv, psta);
> > if (stainfo_offset_valid(stainfo_offset))
> > chk_alive_list[chk_alive_num++] = stainfo_offset;
>
> Umm... Sreenath?
>
> There's 97 more occurrences of the same problem in that file.
>
> All: Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?
>
next prev parent reply other threads:[~2015-07-08 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 1:53 [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c Sreenath Madasu
2015-07-07 4:04 ` Greg KH
2015-07-07 19:32 ` Valdis.Kletnieks
2015-07-07 20:38 ` Joe Perches
2015-07-08 2:08 ` Valdis.Kletnieks
2015-07-08 2:53 ` Joe Perches
2015-07-08 1:08 ` Sreenath Madasu [this message]
2015-07-08 2:06 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708010810.GA2563@sreenath-gentoo.lan \
--to=sreenath.madasu@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=devel@driverdev.osuosl.org \
--cc=jteki@openedev.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox