From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758123AbbGHDtP (ORCPT ); Tue, 7 Jul 2015 23:49:15 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:33398 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758062AbbGHDs7 (ORCPT ); Tue, 7 Jul 2015 23:48:59 -0400 Date: Wed, 8 Jul 2015 12:49:28 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v6 7/7] zsmalloc: use shrinker to trigger auto-compaction Message-ID: <20150708034928.GB1520@swordfish> References: <1436270221-17844-1-git-send-email-sergey.senozhatsky@gmail.com> <1436270221-17844-8-git-send-email-sergey.senozhatsky@gmail.com> <20150707134445.GD3898@blaptop> <20150707144107.GC1450@swordfish> <20150707150143.GC23003@blaptop> <20150707151204.GE1450@swordfish> <20150708021836.GA1520@swordfish> <20150708030410.GA873@blaptop.AC68U> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150708030410.GA873@blaptop.AC68U> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/08/15 12:04), Minchan Kim wrote: > Hi Sergey, > Hi Minchan, [..] > > (a) we need something to signify that zs_unregister_shrinker() was successful > > I think a) is simple way to handle it now. > I don't want to stuck with this issue. > > Please comment out why we need such boolean so after someone who has interest > on shrinker clean-up is able to grab a chance. OK, sure. Do you think that (c) deserves a separate discussion (I can fork a new discussion thread and Cc more people). It does look like we can do a bit better and make shrinker less fragile (and probably cleanup/fix several places in the kernel). -ss