From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758764AbbGHKzh (ORCPT ); Wed, 8 Jul 2015 06:55:37 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:33132 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758232AbbGHKzg (ORCPT ); Wed, 8 Jul 2015 06:55:36 -0400 Date: Wed, 8 Jul 2015 12:55:31 +0200 From: Ingo Molnar To: Andy Shevchenko Cc: "David E. Box" , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH v1 0/4] iosf_mbi: clean up Message-ID: <20150708105530.GA11890@gmail.com> References: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com> <20150708093641.GA1989@gmail.com> <1436349642.10819.60.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436349642.10819.60.camel@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andy Shevchenko wrote: > On Wed, 2015-07-08 at 11:36 +0200, Ingo Molnar wrote: > > * Andy Shevchenko wrote: > > > > > There are few patches to clean up (with small fixes) iosf_mbi > > > driver along with > > > extension it to cover Intel Tangier. > > > > > > Andy Shevchenko (4): > > > iosf_mbi: check result for all calls of debugfs API > > > iosf_mbi: pci_dev_put() is NULL-proof > > > iosf_mbi: group global variables > > > iosf_mbi: append Intel Tangier ID > > > > > > arch/x86/include/asm/iosf_mbi.h | 8 ++++---- > > > arch/x86/kernel/iosf_mbi.c | 31 +++++++++++++++-------------- > > > -- > > > 2 files changed, 19 insertions(+), 20 deletions(-) > > > > Could you please also move it from arch/x86/kernel/ to > > arch/x86/platform/[intel-quark?] while at it? > > I will think about proper folder (apparently not quark, since it is > specific to man different Intel SoCs). Yeah, you could make it arch/x86/platform/iosf/, and the file would be arch/x86/platform/iosf/mbi.c? Or something like that? > > > > arch/x86/kernel/ is the wrong place for this driver. > > Would be okay to send an additional patch or better to regenerate the whole > series? So it might be better to first do the file movement, then the fixes. It should be relatively easy to regenerate the patches like that, and if any failure is bisected back to a commit it's easy to revert - or if some new review observation comes in then it will be easy to adjust the series. Thanks, Ingo