public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>, Christoph Lameter <cl@linux.com>,
	Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2/3] kmod: Add up-to-date explanations on the purpose of each asynchronous levels
Date: Wed, 8 Jul 2015 14:54:50 +0200	[thread overview]
Message-ID: <20150708125449.GB9181@lerouge> (raw)
In-Reply-To: <20150707160758.b1d2dbdd1163c735fc2ee353@linux-foundation.org>

On Tue, Jul 07, 2015 at 04:07:58PM -0700, Andrew Morton wrote:
> On Mon,  6 Jul 2015 17:33:40 +0200 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 
> > There seem to be quite some confusions on the comments, likely due to
> > changes that came after them.
> > 
> > Now since it's very non obvious why we have 3 levels of asynchronous
> > code to implement usermodehelpers, it's important to comment in detail
> > the reason of this layout.
> 
> There are still a few references to keventd in there.  One of them is
> simply wrong: "runs as a child of keventd".  The userspace code is
> actually a child of the khelper thread, yes?
> 
> I guess we should remove all kernel references to "keventd".  It got
> renamed to "kworker".

Right, I think I missed them because I confused khelper with keventd.
In fact here they are all children of khelper, which is the singlethread
workqueue tied to kmod.

But I'm working on a new iteration that makes use of a global no numa
workqueue.

  reply	other threads:[~2015-07-08 12:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 15:33 [PATCH 0/3] kmod: Make nohz-full friendly + cleanups Frederic Weisbecker
2015-07-06 15:33 ` [PATCH 1/3] kmod: Bunch of internal functions renames Frederic Weisbecker
2015-07-06 15:33 ` [PATCH 2/3] kmod: Add up-to-date explanations on the purpose of each asynchronous levels Frederic Weisbecker
2015-07-07 23:07   ` Andrew Morton
2015-07-08 12:54     ` Frederic Weisbecker [this message]
2015-07-06 15:33 ` [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity setting Frederic Weisbecker
2015-07-07 16:30   ` Oleg Nesterov
2015-07-07 17:10     ` Frederic Weisbecker
2015-07-07 17:36       ` Oleg Nesterov
2015-07-07 17:38         ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150708125449.GB9181@lerouge \
    --to=fweisbec@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox