From: Ingo Molnar <mingo@kernel.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
mingo@redhat.com, Mathieu Poirier <mathieu.poirier@linaro.org>,
Serge Broslavsky <serge.broslavsky@linaro.org>,
broonie@kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Lyra Zhang <zhang.lyra@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks
Date: Wed, 8 Jul 2015 15:22:08 +0200 [thread overview]
Message-ID: <20150708132207.GA23380@gmail.com> (raw)
In-Reply-To: <CAG2=9p_quGLBe=fuSTqqjqS0NppO5E0KWMUSybkLFo5TO72nZg@mail.gmail.com>
* Chunyan Zhang <zhang.chunyan@linaro.org> wrote:
> >> +++ b/include/trace/perf.h
> >> @@ -175,6 +175,7 @@ trace_event_raw_event_##call(void *__data, proto) \
> >> { assign; } \
> >> \
> >> trace_event_buffer_commit(&fbuffer); \
> >> + trace_event_stm_log(&fbuffer); \
> >
> > This makes every trace event slower.
>
> It doesn't actually, you may decide if enable this feature, the trace event will
> not be slowed if STM_TRACE_EVENT is not selected.
It slows down everyone if a distro enables this feature - that's not acceptable.
Thanks,
Ingo
next prev parent reply other threads:[~2015-07-08 13:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 10:10 [RFC PATCH v3 0/4] Integration of trace events with System Trace IP blocks Chunyan Zhang
2015-07-07 10:10 ` [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver Chunyan Zhang
2015-07-08 10:23 ` Alexander Shishkin
2015-07-08 14:15 ` Mathieu Poirier
2015-07-08 12:10 ` Peter Zijlstra
2015-07-08 13:09 ` Alexander Shishkin
2015-07-07 10:10 ` [RFC PATCH v3 2/4] trace: Add an entry for printing trace log to STM Chunyan Zhang
2015-07-07 15:58 ` Steven Rostedt
2015-07-08 8:06 ` Chunyan Zhang
2015-07-07 10:10 ` [RFC PATCH v3 3/4] trace: Introduce trace log output function for STM Chunyan Zhang
2015-07-17 20:48 ` Steven Rostedt
2015-07-07 10:10 ` [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks Chunyan Zhang
2015-07-08 12:31 ` Peter Zijlstra
2015-07-08 13:06 ` Chunyan Zhang
2015-07-08 13:22 ` Ingo Molnar [this message]
2015-07-08 13:19 ` Steven Rostedt
2015-07-10 9:01 ` Chunyan Zhang
2015-07-17 5:59 ` Chunyan Zhang
2015-07-17 21:07 ` Steven Rostedt
2015-07-07 11:12 ` [RFC PATCH v3 0/4] Integration of trace events with System Trace IP blocks Alexander Shishkin
2015-07-08 7:42 ` Chunyan Zhang
2015-07-08 10:11 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708132207.GA23380@gmail.com \
--to=mingo@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serge.broslavsky@linaro.org \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox