From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbbGIEIj (ORCPT ); Thu, 9 Jul 2015 00:08:39 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:17412 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750776AbbGIEIc (ORCPT ); Thu, 9 Jul 2015 00:08:32 -0400 Date: Thu, 9 Jul 2015 00:09:01 -0400 From: Steven Rostedt To: Linus Torvalds Cc: LKML , Jan Kara , Paul Moore , Andrew Morton Subject: Re: [PATCH] Revert: audit: Fix check of return value of strnlen_user() Message-ID: <20150709000901.79982402@grimm.local.home> In-Reply-To: <20150708122943.4716f7c3@gandalf.local.home> References: <20150708112607.03df9c2a@gandalf.local.home> <20150708115939.60cd659c@gandalf.local.home> <20150708120249.2ca05313@gandalf.local.home> <20150708122943.4716f7c3@gandalf.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jul 2015 12:29:43 -0400 Steven Rostedt wrote: > I tested the following patch. Feel free to author it yourself and just > add my reported/tested-by tags, or give it to me. Either way, I don't > care. I just want it fixed so that it doesn't make my own tests fail. > OK, you posted your version of the patch, and you just had to include the quote from me that happened to have a grammar mistake: As reported by Steven Rostedt: "Yes, strnlen_user() returns 0 on fault, but if you look at what len is set to, than you would notice that on fault len would be -1" Ug, my "than" stupidity is forever carved in the git stone logs. At least you didn't stick a "(sic)" in there. -- Steve