* [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
@ 2015-07-09 2:50 rcodin
2015-07-09 5:35 ` Sudip Mukherjee
2015-07-09 5:59 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: rcodin @ 2015-07-09 2:50 UTC (permalink / raw)
To: gregkh
Cc: arve, riandrews, sumit.semwal, mitchelh, tranmanphong, ronit.crj,
elfring, linux, devel, linux-kernel
From: Ronit Halder <ronit.crj@gmail.com>
Fixed a coding style issue.
Signed-off-by: Ronit Halder <ronit.crj@gmail.com>
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
struct ion_buffer *buffer;
struct dma_buf *dmabuf;
bool valid_handle;
+
DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
mutex_lock(&client->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
2015-07-09 2:50 [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue rcodin
@ 2015-07-09 5:35 ` Sudip Mukherjee
2015-07-09 5:58 ` Ronit Halder
2015-07-09 5:59 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-07-09 5:35 UTC (permalink / raw)
To: rcodin
Cc: gregkh, devel, tranmanphong, linux-kernel, linux, riandrews,
elfring, arve, sumit.semwal
On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> From: Ronit Halder <ronit.crj@gmail.com>
You do not need a From: here. Please fix your gitconfig file and
git send-email will give your name correctly in the email header.
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
2015-07-09 5:35 ` Sudip Mukherjee
@ 2015-07-09 5:58 ` Ronit Halder
0 siblings, 0 replies; 6+ messages in thread
From: Ronit Halder @ 2015-07-09 5:58 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: devel, tranmanphong, gregkh, linux, linux-kernel, sumit.semwal,
riandrews, arve, elfring
On Thu, 2015-07-09 at 11:05 +0530, Sudip Mukherjee wrote:
> On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> > From: Ronit Halder <ronit.crj@gmail.com>
>
> You do not need a From: here. Please fix your gitconfig file and
> git send-email will give your name correctly in the email header.
>
> regards
> sudip
thanks for pointing it sudip.
Sorry for the stupid mistake, version 2 of the patch is coming.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
2015-07-09 2:50 [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue rcodin
2015-07-09 5:35 ` Sudip Mukherjee
@ 2015-07-09 5:59 ` Greg KH
2015-07-09 9:57 ` Joe Perches
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2015-07-09 5:59 UTC (permalink / raw)
To: rcodin
Cc: arve, riandrews, sumit.semwal, mitchelh, tranmanphong, elfring,
linux, devel, linux-kernel
On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> From: Ronit Halder <ronit.crj@gmail.com>
>
> Fixed a coding style issue.
>
> Signed-off-by: Ronit Halder <ronit.crj@gmail.com>
> ---
> drivers/staging/android/ion/ion.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> struct ion_buffer *buffer;
> struct dma_buf *dmabuf;
> bool valid_handle;
> +
> DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
This is a false positive and has been rejected so many times it's really
getting old...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
2015-07-09 5:59 ` Greg KH
@ 2015-07-09 9:57 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2015-07-09 9:57 UTC (permalink / raw)
To: Greg KH
Cc: rcodin, arve, riandrews, sumit.semwal, mitchelh, tranmanphong,
elfring, linux, devel, linux-kernel
On Wed, 2015-07-08 at 22:59 -0700, Greg KH wrote:
> On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> > Fixed a coding style issue.
[]
> > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
[]
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> > struct ion_buffer *buffer;
> > struct dma_buf *dmabuf;
> > bool valid_handle;
> > +
> > DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>
> This is a false positive and has been rejected so many times it's really
> getting old...
There's a checkpatch patch for that that'll eventually get applied.
https://lkml.org/lkml/2015/7/1/383
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
@ 2015-07-09 5:33 Ronit Halder
0 siblings, 0 replies; 6+ messages in thread
From: Ronit Halder @ 2015-07-09 5:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Ronit Halder
Fixed a coding style issue.
Signed-off-by: Ronit Halder <ronit.crj@gmail.com>
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
struct ion_buffer *buffer;
struct dma_buf *dmabuf;
bool valid_handle;
+
DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
mutex_lock(&client->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-09 9:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-09 2:50 [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue rcodin
2015-07-09 5:35 ` Sudip Mukherjee
2015-07-09 5:58 ` Ronit Halder
2015-07-09 5:59 ` Greg KH
2015-07-09 9:57 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2015-07-09 5:33 Ronit Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox